Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FutureMono and use Mono.fromCompletionStage #2250

Merged
merged 1 commit into from May 25, 2022
Merged

Remove FutureMono and use Mono.fromCompletionStage #2250

merged 1 commit into from May 25, 2022

Conversation

violetagg
Copy link
Member

Related to #1873

@violetagg violetagg added the type/enhancement A general enhancement label May 25, 2022
@violetagg violetagg added this to the 2.0.0-M1 milestone May 25, 2022
@violetagg violetagg requested a review from a team May 25, 2022 13:23
@violetagg
Copy link
Member Author

Once this is resolved, we can close #330

pderop
pderop approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@violetagg
Copy link
Member Author

@pderop Thanks for the review!

@violetagg violetagg merged commit 82ba27e into netty5 May 25, 2022
@violetagg violetagg deleted the remove-future-mono branch May 25, 2022 14:44
@violetagg violetagg mentioned this pull request May 25, 2022
Closed
@violetagg violetagg mentioned this pull request Nov 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@violetagg @pderop