Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Fix warnings "unchecked method invocation"/"unchecked conversion" #2355

Merged
merged 1 commit into from
Jul 4, 2022
Merged

[test] Fix warnings "unchecked method invocation"/"unchecked conversion" #2355

merged 1 commit into from
Jul 4, 2022

Conversation

violetagg
Copy link
Member 

/.../reactor-netty/reactor-netty-http/src/test/java/reactor/netty/http/observability/ObservabilitySmokeTest.java:99:
 warning: [unchecked] unchecked method invocation: method addLast in interface Deque is applied to given types
                        timerRecordingHandlers.addLast(defaultHandler);
                                                      ^
  required: E
  found: ObservationHandler
  where E is a type-variable:
    E extends Object declared in interface Deque
/.../reactor-netty/reactor-netty-http/src/test/java/reactor/netty/http/observability/ObservabilitySmokeTest.java:99:
 warning: [unchecked] unchecked conversion
                        timerRecordingHandlers.addLast(defaultHandler);
                                                       ^
  required: E
  found:    ObservationHandler
  where E is a type-variable:
    E extends Object declared in interface Deque

@violetagg
[test] Fix warnings "unchecked method invocation"/"unchecked conversion"
af216c6 
```
/.../reactor-netty/reactor-netty-http/src/test/java/reactor/netty/http/observability/ObservabilitySmokeTest.java:99:
 warning: [unchecked] unchecked method invocation: method addLast in interface Deque is applied to given types
                        timerRecordingHandlers.addLast(defaultHandler);
                                                      ^
  required: E
  found: ObservationHandler
  where E is a type-variable:
    E extends Object declared in interface Deque
/.../reactor-netty/reactor-netty-http/src/test/java/reactor/netty/http/observability/ObservabilitySmokeTest.java:99:
 warning: [unchecked] unchecked conversion
                        timerRecordingHandlers.addLast(defaultHandler);
                                                       ^
  required: E
  found:    ObservationHandler
  where E is a type-variable:
    E extends Object declared in interface Deque
```
@violetagg violetagg added the type/chore A task not related to code (build, formatting, process, ...) label Jul 4, 2022
@violetagg violetagg added this to the 1.1.0-M4 milestone Jul 4, 2022
@violetagg violetagg requested a review from a team July 4, 2022 18:17
pderop
pderop approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@violetagg
Copy link
Member Author

@pderop Thanks

@violetagg violetagg merged commit a34db4e into main Jul 4, 2022
@violetagg violetagg deleted the warnings-unchecked branch July 4, 2022 18:45
violetagg added a commit that referenced this pull request Jul 4, 2022
@violetagg
Merge #2355 into netty5
d824464
pderop added a commit to pderop/reactor-netty that referenced this pull request Jul 5, 2022
@pderop
Merge reactor#2355 from 'netty5' branch.
d25c858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/chore A task not related to code (build, formatting, process, ...)
Projects
None yet
Milestone
1.1.0-M4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@violetagg @pderop