Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to the new EventLoop API for checking the channel compatibility #2367

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Adapt to the new EventLoop API for checking the channel compatibility #2367

merged 2 commits into from
Jul 8, 2022

Conversation

violetagg
Copy link
Member

Fixes #2291

@violetagg violetagg added the type/enhancement A general enhancement label Jul 8, 2022
@violetagg violetagg added this to the 2.0.0-M1 milestone Jul 8, 2022
@violetagg violetagg requested a review from a team July 8, 2022 10:55
@violetagg violetagg linked an issue Jul 8, 2022 that may be closed by this pull request
Enable the check for the type of the executor #2291
Closed
@pderop
Copy link
Member

pderop commented Jul 8, 2022

should we ignore the CI checks errors ?

@violetagg
Copy link
Member Author

No I need to check why the UDS tests are failing

pderop
pderop approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pderop
Copy link
Member

pderop commented Jul 8, 2022

ignore my last LGTM, sorry, that was a mistake 😊. Will review again after tests have passed.

@violetagg
Copy link
Member Author

@pderop I created an issue for HttpMetricsHandlerTests > testServerConnectionsRecorder as I observe this test to fail on all versions from time to time.
I do not consider it related to this change.

pderop
pderop approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@violetagg
Copy link
Member Author

@pderop Thanks

@violetagg violetagg merged commit 57f82b7 into netty5 Jul 8, 2022
@violetagg violetagg deleted the event-loop-is-compatible branch July 8, 2022 12:06
pderop added a commit to pderop/reactor-netty that referenced this pull request Jul 8, 2022
@pderop
Merge reactor#2365, reactor#2366, reactor#2367 from netty5 branch
79dfc9e
@violetagg
Copy link
Member Author

Related to #1873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.

Enable the check for the type of the executor
2 participants
@violetagg @pderop