Allow HTTP1.1, H2, and H2C protocol for HttpClient
#2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alextychan Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@alextychan Thank you for signing the Contributor License Agreement! |
violetagg
requested changes
Jan 24, 2023
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConnect.java
Outdated
Show resolved
Hide resolved
reactor-netty-http/src/main/java/reactor/netty/http/client/HttpClientConnect.java
Outdated
Show resolved
Hide resolved
Enable H1, H2, and H2C protocols for HttpClient by dropping H2C protocol when handling HTTPS urls, and by dropping H2 protocol when handling HTTP urls when another protocol is present Signed-off-by: TaiYau Chan <alextychan@gmail.com>
alextychan
force-pushed
the
allow-h1-h2-h2c-protocols-for-httpclient
branch
from
232f38c
to
6241b24
Compare
|
I've only added tests for edge cases where the client is configured with all 3 types of protocol for the following cases.
|
violetagg
approved these changes
Jan 26, 2023
|
The failing QUIC tests on CI are not related |
pderop
approved these changes
Jan 26, 2023
violetagg
added a commit
that referenced
this pull request
Jan 26, 2023
violetagg
pushed a commit
that referenced
this pull request
Jan 26, 2023
Enable H1, H2, and H2C protocols for HttpClient by dropping H2C protocol when handling HTTPS urls, and by dropping H2 protocol when handling HTTP urls when another protocol is present This is a backport for PR #2659 Signed-off-by: TaiYau Chan <alextychan@gmail.com>
violetagg
changed the title
HTTP1.1, H2, and H2C protocol for HttpClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a client that's configured for HTTP 1.1, H2, and H2C is unable to make requests to both HTTPS and HTTP urls due to checks in HttpClientConnect.java which can be safely ignored as long as a backup protocol is configured.
The following changes are in line with discussion in this PR #1403. Specifically the table as follows.
H2}httpH2}httpsH2(pre-known)H2C}httpH2C(pre-known)H2C}httpsHTTP11}httpHTTP11HTTP11}httpsHTTP11H2,H2C}httpH2C(pre-known)H2,H2C}httpsH2(pre-known)H2,HTTP11}httpHTTP11H2,HTTP11}httpsH2(offered via ALPN, fallback toHTTP11)H2C,HTTP11}httpH2C(offered viaUpgradeheader, fallback toHTTP11)H2C,HTTP11}httpsHTTP11H2,H2C,HTTP11}httpH2C(offered viaUpgradeheader, fallback toHTTP11).H2,H2C,HTTP11}httpsH2(offered via ALPN, fallback toHTTP11)This fix will allow clients configured with HTTP 1.1, H2, and H2C to work as expected by ignoring H2C in HTTPS, and by ignoring H2 in HTTP.