Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend HttpClient/HttpServer combinations used for HttpMetricsHandlerTests #2668

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Extend HttpClient/HttpServer combinations used for HttpMetricsHandlerTests #2668

merged 1 commit into from
Jan 25, 2023

Conversation

violetagg
Copy link
Member

No description provided.

@violetagg violetagg added the type/test A general test label Jan 24, 2023
@violetagg violetagg added this to the 1.0.28 milestone Jan 24, 2023
@violetagg violetagg requested a review from a team January 24, 2023 19:31
pderop
pderop approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@violetagg
Copy link
Member Author

@pderop Thanks for the review!

@violetagg violetagg merged commit 8b454bb into 1.0.x Jan 25, 2023
@violetagg violetagg deleted the tests-missing-combinations branch January 25, 2023 09:04
violetagg added a commit that referenced this pull request Jan 25, 2023
@violetagg
Merge #2668 into 1.1.3
168475e
violetagg added a commit that referenced this pull request Jan 25, 2023
@violetagg
Merge #2668 into 2.0.0-M4
a895730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/test A general test
Projects
None yet
Milestone
1.0.28
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@violetagg @pderop