Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure server will send a response in case websocket upgrade failure #268

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

violetagg
Copy link
Member

@violetagg violetagg commented Jan 31, 2018

Fix for #269

@violetagg violetagg added this to the 0.7.4.RELEASE milestone Jan 31, 2018
@codecov-io
Copy link

codecov-io commented Jan 31, 2018

Codecov Report

Merging #268 into master will decrease coverage by 0.41%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #268      +/-   ##
============================================
- Coverage     67.75%   67.33%   -0.42%     
+ Complexity     1008     1002       -6     
============================================
  Files            73       73              
  Lines          4258     4259       +1     
  Branches        604      605       +1     
============================================
- Hits           2885     2868      -17     
- Misses         1011     1024      +13     
- Partials        362      367       +5
Impacted Files Coverage Δ Complexity Δ
...or/ipc/netty/http/server/HttpServerOperations.java 68.45% <0%> (-0.41%) 47 <0> (+1)
...ctor/ipc/netty/resources/DefaultPoolResources.java 74.64% <0%> (-4.23%) 8% <0%> (-1%)
src/main/java/reactor/ipc/netty/FutureMono.java 81.63% <0%> (-4.09%) 4% <0%> (-1%)
...a/reactor/ipc/netty/channel/ChannelOperations.java 81.95% <0%> (-3.01%) 47% <0%> (-2%)
...java/reactor/ipc/netty/channel/ContextHandler.java 71.56% <0%> (-2.95%) 26% <0%> (-1%)
.../ipc/netty/channel/PooledClientContextHandler.java 58.53% <0%> (-1.63%) 24% <0%> (-1%)
...or/ipc/netty/http/client/HttpClientOperations.java 54.17% <0%> (-1.62%) 71% <0%> (-2%)
.../ipc/netty/http/client/MonoHttpClientResponse.java 82.19% <0%> (+4.1%) 6% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64d803a...d612d0a. Read the comment docs.

@violetagg violetagg merged commit d612d0a into master Jan 31, 2018
@violetagg violetagg deleted the server-websocket-failed branch January 31, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants