Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When graceful shutdown, ensure the streams are processed before closing connection #2736

Merged
merged 2 commits into from
Mar 22, 2023
Merged

When graceful shutdown, ensure the streams are processed before closing connection #2736

merged 2 commits into from
Mar 22, 2023

Conversation

violetagg
Copy link
Member

Fixes #2735

@violetagg violetagg added the type/bug A general bug label Mar 22, 2023
@violetagg violetagg added this to the 1.0.31 milestone Mar 22, 2023
@violetagg violetagg requested a review from a team March 22, 2023 09:15
@violetagg violetagg linked an issue Mar 22, 2023 that may be closed by this pull request
Server closes the connection with a FIN packet immediately after sending a GO_AWAY frame. All accepted streams upto the lastStreamId are not getting processed #2735
Closed
@violetagg violetagg changed the title When graceful shutdown, ensure the streams are process before closing connection When graceful shutdown, ensure the streams are processed before closing connection Mar 22, 2023
pderop
pderop approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, nice patch, looks good to me.

@violetagg
Copy link
Member Author

HttpClientTest > testHttpClientCancelled() is failing on Windows OS. I checked the test and it does not enable graceful shutdown. So my opinion is that this failure is not because of this change.

https://github.com/reactor/reactor-netty/actions/runs/4488211188/jobs/7893282178#step:5:157

@violetagg violetagg merged commit 5dd2034 into 1.0.x Mar 22, 2023
@violetagg violetagg deleted the issue-2735 branch March 22, 2023 13:31
violetagg added a commit that referenced this pull request Mar 22, 2023
@violetagg
Merge #2736 into 1.1.6
360fd34
violetagg added a commit that referenced this pull request Mar 22, 2023
@violetagg
Merge #2736 into 2.0.0-M4
0448160
violetagg added a commit that referenced this pull request Mar 22, 2023
@violetagg
Merge #2736 into 2.0.0-M4
c67bb76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robotmrv robotmrv robotmrv left review comments

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/bug A general bug
Projects
None yet
Milestone
1.0.31
3 participants
@violetagg @pderop @robotmrv