Support a custom DnsAddressResolverGroup builder function
#2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pderop
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Hi @samueldlightfoot ,
thanks for this PR.
One minor thing: can you update the equals and hashCode methods with the new introduced dnsAddressResolverGroupProvider attribute ?
samueldlightfoot
force-pushed
the
address-resolver-provider
branch
from
ba4d8ba
to
378a0e0
Compare
Nice spot. Done. |
pderop
approved these changes
Mar 27, 2023
violetagg
approved these changes
Mar 27, 2023
violetagg
changed the title
DnsAddressResolverGroup builder function
pderop
added a commit
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support a user provided function to build a DnsAddressResolverGroup