Add Brotli compression test
#2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sullis
force-pushed
the
add-brotli-compression-test
branch
3 times, most recently
from
33ae09e
to
79aa324
Compare
violetagg
requested changes
May 29, 2023
reactor-netty-http/src/main/java/reactor/netty/http/server/SimpleCompressionHandler.java
Outdated
Show resolved
Hide resolved
sullis
force-pushed
the
add-brotli-compression-test
branch
from
0f5cb25
to
2eb7cf2
Compare
|
fyi @hyperxpro |
|
@violetagg Thanks for the feedback! I incorporated your suggestions and I squashed the commits. |
sullis
force-pushed
the
add-brotli-compression-test
branch
from
2eb7cf2
to
24aa10e
Compare
violetagg
reviewed
May 29, 2023
sullis
force-pushed
the
add-brotli-compression-test
branch
from
b03c1ca
to
83585a2
Compare
|
The failure on Windows OS is a flaky test |
violetagg
approved these changes
May 29, 2023
|
@reactor/netty-team PTAL |
hyperxpro
reviewed
May 30, 2023
|
Please hold off on this PR until I release 1.12.0 in the next 2 days. |
sure |
sullis
force-pushed
the
add-brotli-compression-test
branch
from
83585a2
to
3e900d7
Compare
|
fyi, I upgraded this PR to brotli4j 1.12.0 |
|
LGTM :) |
hyperxpro
approved these changes
May 30, 2023
violetagg
added
type/test
violetagg
added a commit
that referenced
this pull request
May 31, 2023
violetagg
pushed a commit
that referenced
this pull request
Jun 29, 2023
|
The change is back ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Netty 4.x supports Brotli compression. Brotli compression is available if and only if the Brotli4j library is on the runtime classpath.