Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure handshake timeout is applied in case of SNI #2840

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

violetagg
Copy link
Member

No description provided.

@violetagg violetagg added the type/bug A general bug label Jun 21, 2023
@violetagg violetagg added this to the 1.0.34 milestone Jun 21, 2023
@violetagg violetagg requested a review from a team June 21, 2023 12:19
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good.

just one minor thing: maybe it would be worth increasing the test verify duration, just in case the CI is very slow).

@violetagg violetagg merged commit 877e20c into 1.0.x Jun 21, 2023
9 checks passed
@violetagg violetagg deleted the sni-handshake-timeout branch June 21, 2023 14:04
violetagg added a commit that referenced this pull request Jun 21, 2023
@violetagg
Copy link
Member Author

@pderop Thanks

violetagg added a commit that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants