fix #293 support expect 100-continue #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaldini
force-pushed
the
293-expect100continue
branch
from
495ecf8
to
e51c645
Compare
HttpServerHandler now write informational response separately. In order to fully work the fix correctly defers header sending on subscribe. This can give precedence to the expect100Continue logic in receiveObject()
As a server response, if no identified message length, do not persist As a server empty body response, always assume persist As a client request, do not assume anything
- Correctly defer cleanHandlerTerminate in HttpServerHandler - Manage markPersistent(true) in a single HttpServerOp method - Override sendObject for client to force chunked transfer on send if: - Not head verb, not header sent, no length defined - Delegate sendHeader() implementation to then() - Try to create FullHttpMessage if contentLength defined and 0
smaldini
force-pushed
the
293-expect100continue
branch
from
aebfbc0
to
c7031e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
============================================
- Coverage 67.92% 67.92% -0.01%
- Complexity 1021 1027 +6
============================================
Files 74 74
Lines 4306 4318 +12
Branches 617 615 -2
============================================
+ Hits 2925 2933 +8
- Misses 1008 1017 +9
+ Partials 373 368 -5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpServerHandler now write informational response separately.
In order to fully work the fix correctly defers header sending on subscribe.
This can give precedence to the expect100Continue logic in receiveObject()