fix #292 refactor gzip compression handler #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 27, 2018 01:22
Previously the logic was not updating the buffer pending bytes. Thus would prevent flush logic to operate correctly. Also A convoluted FilteringCompressor was used.
Add HttpServerResponse#compression to control per response compression.
We don't need to wrap non reactor types, and we need to leave callable source takes precedence
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
============================================
- Coverage 68.11% 66.92% -1.19%
+ Complexity 1030 1012 -18
============================================
Files 74 74
Lines 4318 4332 +14
Branches 615 615
============================================
- Hits 2941 2899 -42
- Misses 1006 1065 +59
+ Partials 371 368 -3
Continue to review full report at Codecov.
|
smaldini
changed the title
rstoyanchev
reviewed
Feb 28, 2018
| .subscriberContext(context); | ||
| } | ||
|
|
||
| static <T, V> Publisher<V> publiserOrScalarMap(Publisher<T> publisher, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we have tried to refactor CompressionHandler to correctly aggregate bytes until threshold. Unfortunately it is now put on hold as it still presents stability issues that we eventually will identify in a subsequent PR.
Now the PR introduces a new simple CompressionHandler that will compress without minimum threshold all traffic, HttpServers can choose to opt-in/opt-on the globally configured default on a per-response basis by using HttpServerResponse#compression(boolean).