Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated SslProvider$DefaultConfigurationSpec and SslProvider$DefaultConfigurationType #3147

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

violetagg
Copy link
Member

This is a problematic deprecated API that we would like to remove sooner than later.

This is in preparation for HTTP/3 support.

@violetagg violetagg added type/enhancement A general enhancement warn/api-change Breaking change with compilation errors labels Apr 11, 2024
@violetagg violetagg added this to the 1.2.0-M2 milestone Apr 11, 2024
@violetagg violetagg requested review from chemicL and a team April 11, 2024 08:01
….java

Co-authored-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
Copy link
Member

@chemicL chemicL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small toString issue noticed, but otherwise looks good. Was there no test coverage for these deprecated mechanisms?

@violetagg
Copy link
Member Author

Was there no test coverage for these deprecated mechanisms?

We removed the usage in tests long time ago #1573

@violetagg
Copy link
Member Author

@chemicL Thanks

@violetagg violetagg merged commit d81413e into main Apr 11, 2024
14 checks passed
@violetagg violetagg deleted the remove-deprecation branch April 11, 2024 09:01
violetagg added a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement warn/api-change Breaking change with compilation errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants