Make ProtocolSslContextSpec generic
#3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- QuicSslContextBuilder does not extend SslContextBuilder. - Add Http3SslContextSpec, similar to Http2SslContextSpec and Http11SslContextSpec. Related to #1531
pderop
reviewed
Apr 15, 2024
pderop
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
+1
as discussed, maybe we can deprecate the old sslContext(ProtocolSslContextSpec spec)signature in SslProvider.SslContextSpec.
Something like:
/**
* SslContext builder that provides, specific for the protocol, default configuration
* e.g. {@link DefaultSslContextSpec}, {@link TcpSslContextSpec} etc.
* The default configuration is applied before any other custom configuration.
*
* @param spec SslContext builder that provides, specific for the protocol, default configuration
* @return {@literal this}
* @since 1.0.6
* @deprecated as of 1.2.0. Prefer using {@link #sslContext(SslProvider.GenericSslContextSpec)}
* This method will be removed in version 1.3.0.
*/
@Deprecated
Builder sslContext(ProtocolSslContextSpec spec);
ok I will deprecate with a separate PR |
violetagg
added a commit
that referenced
this pull request
Apr 16, 2024
Netty Quic Codec and HTTP3 Codec are not migrated to Netty5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuicSslContextBuilderdoes not extendSslContextBuilder.Http3SslContextSpec, similar toHttp2SslContextSpecandHttp11SslContextSpec.Related to #1531