Add handling of offset and length to NettyOutbound#sendFileChunked #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lhotari
commented
Apr 12, 2018
lhotari
commented
- The position and count parameters on reactor.ipc.netty.NettyOutbound#sendFileChunked method calls were ignored.
- sendFile tests are now refactored so that same tests are used for both http and https
- new tests for SSL reveal problem with sendFileAsync4096/sendFileAsync1024 (ignored for now)
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
============================================
+ Coverage 68.28% 68.37% +0.09%
- Complexity 1022 1024 +2
============================================
Files 73 73
Lines 4310 4310
Branches 615 615
============================================
+ Hits 2943 2947 +4
+ Misses 996 993 -3
+ Partials 371 370 -1
Continue to review full report at Codecov.
|
violetagg
requested changes
Apr 12, 2018
| protected void customizeClientOptions(HttpClientOptions.Builder options) { | ||
| try { | ||
| options.sslContext(SslContextBuilder | ||
| .forServer(ssc.certificate(), ssc.privateKey()).build()); |
There was a problem hiding this comment.
Why do you create SslContext for server when customising the client options?
| @Override | ||
| protected void customizeServerOptions(HttpServerOptions.Builder options) { | ||
| try { | ||
| options.sslContext(SslContextBuilder.forClient() |
There was a problem hiding this comment.
Why do you create SslContext for client when customising the server options?
- new tests for SSL reveal problem with sendFileAsync4096/sendFileAsync1024 when SSL is used
lhotari
force-pushed
the
lh-ssl-send-file-offset
branch
from
9c7b815
to
1820d20
Compare
violetagg
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.