Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #332 Ensure CloseWebSocketFrame will be sent by the Server/Client #334

Closed
wants to merge 1 commit into from
Closed

Conversation

violetagg
Copy link
Member

When CloseWebSocketFrame is received by the Server/Client, the inbound
has to be completed so that the CloseWebSocketFrame is process correctly
and send back, otherwise the CloseWebSocketFrame will be stored to the
pending writes but it will not be sent until inbound is competed.

@violetagg violetagg requested a review from smaldini April 24, 2018 12:01
@violetagg violetagg added this to the 0.7.7.RELEASE milestone Apr 24, 2018
@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #334 into master will decrease coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #334      +/-   ##
===========================================
- Coverage     68.54%   68.3%   -0.25%     
+ Complexity     1027    1024       -3     
===========================================
  Files            73      73              
  Lines          4314    4316       +2     
  Branches        614     614              
===========================================
- Hits           2957    2948       -9     
- Misses          989     998       +9     
- Partials        368     370       +2
Impacted Files Coverage Δ Complexity Δ
.../ipc/netty/http/client/HttpClientWSOperations.java 75% <100%> (-3.67%) 18 <0> (-1)
.../ipc/netty/http/server/HttpServerWSOperations.java 62.5% <100%> (+2.5%) 14 <0> (+1) ⬆️
...ctor/ipc/netty/resources/DefaultPoolResources.java 75.86% <0%> (-3.45%) 8% <0%> (-1%)
...java/reactor/ipc/netty/channel/ContextHandler.java 71.56% <0%> (-1.97%) 26% <0%> (-1%)
...actor/ipc/netty/http/server/HttpServerHandler.java 77.62% <0%> (-1.4%) 41% <0%> (-1%)
...or/ipc/netty/channel/ChannelOperationsHandler.java 63.97% <0%> (-1.16%) 59% <0%> (-1%)
...or/ipc/netty/http/client/HttpClientOperations.java 56.31% <0%> (-1.06%) 78% <0%> (-2%)
.../ipc/netty/channel/PooledClientContextHandler.java 68.06% <0%> (+5.04%) 27% <0%> (+2%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d466d1c...0adb13e. Read the comment docs.

When CloseWebSocketFrame is received by the Server/Client, the inbound
has to be completed so that the CloseWebSocketFrame is process correctly
and send back, otherwise the CloseWebSocketFrame will be stored to the
pending writes but it will not be sent until inbound is competed.
@violetagg
Copy link
Member Author

Closed via 9275373

@violetagg violetagg closed this Apr 25, 2018
@violetagg violetagg deleted the issue-332 branch April 26, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants