Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add PENDING_WRITES to the queue if future is DONE #445

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

violetagg
Copy link
Member

When adding to the queue is scheduled operation, check again whether
future is DONE and there are pending write bytes.

When adding to the queue is scheduled operation, check again whether
future is DONE and there are pending write bytes.
@violetagg violetagg added this to the 0.7.10.RELEASE milestone Oct 2, 2018
@codecov-io
Copy link

codecov-io commented Oct 2, 2018

Codecov Report

Merging #445 into 0.7.x will increase coverage by 0.36%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             0.7.x     #445      +/-   ##
===========================================
+ Coverage     68.1%   68.46%   +0.36%     
- Complexity    1054     1058       +4     
===========================================
  Files           73       73              
  Lines         4512     4513       +1     
  Branches       653      654       +1     
===========================================
+ Hits          3073     3090      +17     
+ Misses        1048     1034      -14     
+ Partials       391      389       -2
Impacted Files Coverage Δ Complexity Δ
...or/ipc/netty/channel/ChannelOperationsHandler.java 65.79% <0%> (+0.94%) 60 <0> (ø) ⬇️
...or/ipc/netty/http/client/HttpClientOperations.java 56.73% <0%> (+0.25%) 81% <0%> (+1%) ⬆️
...ctor/ipc/netty/resources/DefaultPoolResources.java 79.38% <0%> (+3.09%) 9% <0%> (+1%) ⬆️
.../ipc/netty/channel/PooledClientContextHandler.java 71.42% <0%> (+4.2%) 28% <0%> (+1%) ⬆️
.../ipc/netty/http/server/HttpServerWSOperations.java 68.42% <0%> (+5.26%) 15% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8db29c...c9199d3. Read the comment docs.

@violetagg violetagg merged commit c9199d3 into 0.7.x Oct 3, 2018
@violetagg violetagg deleted the pending-writes-not-needed-when-future-done branch October 3, 2018 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants