Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra character trimming if baseUrl ends with a slash #461

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

vooft
Copy link
Contributor

@vooft vooft commented Oct 13, 2018

If a baseUrl ends with a slash, one extra character removed from the end of it.

@pivotal-issuemaster
Copy link

@vooft Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@vooft Thank you for signing the Contributor License Agreement!

@codecov-io
Copy link

Codecov Report

Merging #461 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #461      +/-   ##
============================================
+ Coverage     62.92%   62.95%   +0.03%     
+ Complexity     1253     1251       -2     
============================================
  Files           122      122              
  Lines          5988     5988              
  Branches        784      784              
============================================
+ Hits           3768     3770       +2     
+ Misses         1794     1791       -3     
- Partials        426      427       +1
Impacted Files Coverage Δ Complexity Δ
...a/reactor/netty/http/client/HttpClientConnect.java 53.25% <0%> (ø) 4 <0> (ø) ⬇️
src/main/java/reactor/netty/DisposableChannel.java 80.76% <0%> (-3.85%) 9% <0%> (-1%)
...c/main/java/reactor/netty/channel/FluxReceive.java 78.75% <0%> (-0.52%) 60% <0%> (-1%)
...r/netty/http/server/WebsocketServerOperations.java 53.62% <0%> (+1.44%) 15% <0%> (+1%) ⬆️
src/main/java/reactor/netty/FutureMono.java 67.5% <0%> (+2.5%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f91023...f0624f7. Read the comment docs.

@violetagg violetagg merged commit a272acd into reactor:master Oct 14, 2018
@violetagg
Copy link
Member

Thanks

@violetagg violetagg added this to the 0.8.2.RELEASE milestone Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants