fix #460 Ensure errors while upgrading to websocket will be propagated

[violetagg]

No description provided.

[codecov-io]

Codecov Report

Merging #463 into master will increase coverage by 0.14%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##             master   #463      +/-   ##
==========================================
+ Coverage     62.86%    63%   +0.14%     
- Complexity     1252   1256       +4     
==========================================
  Files           122    122              
  Lines          5981   5988       +7     
  Branches        783    784       +1     
==========================================
+ Hits           3760   3773      +13     
+ Misses         1794   1787       -7     
- Partials        427    428       +1

Impacted Files	Coverage Δ	Complexity Δ
...eactor/netty/http/client/HttpClientOperations.java	48.18% <0%> (ø)	61 <0> (ø)	⬇️
src/main/java/reactor/netty/FutureMono.java	65% <0%> (-2.5%)	8% <0%> (ø)
...a/reactor/netty/http/client/HttpClientConnect.java	53.86% <0%> (+0.38%)	4% <0%> (ø)	⬇️
...eactor/netty/channel/ChannelOperationsHandler.java	67.7% <0%> (+1.11%)	63% <0%> (+1%)	⬆️
...ctor/netty/resources/PooledConnectionProvider.java	79.23% <0%> (+1.15%)	20% <0%> (+1%)	⬆️
.../java/reactor/netty/channel/ChannelOperations.java	78.35% <0%> (+1.49%)	57% <0%> (+1%)	⬆️
...n/java/reactor/netty/channel/AbortedException.java	45.45% <0%> (+9.09%)	4% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f7a1e...0ee0000. Read the comment docs.

[smaldini]

I would rather qualify the error with an IllegalArgumentException. I'm suprised it gets caught and i wonder if its hiding a greater issue. Do you know what is catching this exception ?

[violetagg]

Do you know what is catching this exception ?

https://github.com/reactor/reactor-netty/blob/master/src/main/java/reactor/netty/http/client/HttpClientConnect.java#L544