Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #473 Ensure lazy remote address is converted before finalizing handlers #475

Merged
merged 1 commit into from Oct 24, 2018

Conversation

violetagg
Copy link
Member

No description provided.

@violetagg violetagg added this to the 0.8.2.RELEASE milestone Oct 23, 2018
@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #475 into master will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #475      +/-   ##
============================================
+ Coverage     62.99%   63.23%   +0.24%     
- Complexity     1265     1273       +8     
============================================
  Files           122      122              
  Lines          6026     6028       +2     
  Branches        785      786       +1     
============================================
+ Hits           3796     3812      +16     
+ Misses         1803     1795       -8     
+ Partials        427      421       -6
Impacted Files Coverage Δ Complexity Δ
...reactor/netty/resources/NewConnectionProvider.java 72.22% <100%> (+0.79%) 8 <0> (+1) ⬆️
...a/reactor/netty/http/client/HttpClientConnect.java 54.43% <0%> (+0.31%) 4% <0%> (ø) ⬇️
...ctor/netty/resources/PooledConnectionProvider.java 79.23% <0%> (+0.38%) 20% <0%> (ø) ⬇️
...eactor/netty/http/server/HttpServerOperations.java 69.71% <0%> (+0.48%) 61% <0%> (+1%) ⬆️
...c/main/java/reactor/netty/channel/FluxReceive.java 79.27% <0%> (+0.51%) 61% <0%> (+1%) ⬆️
...eactor/netty/channel/ChannelOperationsHandler.java 67.92% <0%> (+0.66%) 64% <0%> (+2%) ⬆️
...ain/java/reactor/netty/http/client/HttpClient.java 74.46% <0%> (+1.06%) 49% <0%> (+1%) ⬆️
src/main/java/reactor/netty/tcp/SslProvider.java 75.4% <0%> (+1.09%) 25% <0%> (ø) ⬇️
...r/netty/http/server/WebsocketServerOperations.java 60.56% <0%> (+1.4%) 18% <0%> (+1%) ⬆️
...va/reactor/netty/http/client/HttpClientSecure.java 86.2% <0%> (+10.34%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56041f7...d5f9aa6. Read the comment docs.

@violetagg violetagg merged commit d5f9aa6 into master Oct 24, 2018
@violetagg violetagg deleted the issue-473 branch October 24, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants