Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #525 HttpServer CONFIGURED moved to HttpTrafficHandler/Http2StreamBridgeHandler #526

Merged
merged 1 commit into from Nov 27, 2018

Conversation

violetagg
Copy link
Member

doOnConnection is invoked when HttpServer reaches state CONFIGURED.
On that state the user can add new handlers to the channel pipeline, because
of that the state's change must happen before ChannelOperationsHandler,
otherwise the new handlers will miss the first channelRead event.

…mBridgeHandler

doOnConnection is invoked when HttpServer reaches state CONFIGURED.
On that state the user can add new handlers to the channel pipeline, because
of that the state's change must happen before ChannelOperationsHandler,
otherwise the new handlers will miss the first channelRead event.
@violetagg violetagg added this to the 0.8.4.RELEASE milestone Nov 27, 2018
@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #526 into master will increase coverage by 0.06%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #526      +/-   ##
============================================
+ Coverage     63.54%   63.61%   +0.06%     
- Complexity     1306     1308       +2     
============================================
  Files           125      125              
  Lines          6285     6286       +1     
  Branches        836      836              
============================================
+ Hits           3994     3999       +5     
+ Misses         1849     1847       -2     
+ Partials        442      440       -2
Impacted Files Coverage Δ Complexity Δ
...eactor/netty/http/server/HttpServerOperations.java 70.72% <ø> (+0.31%) 61 <0> (ø) ⬇️
.../reactor/netty/http/server/HttpToH2Operations.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...or/netty/http/server/Http2StreamBridgeHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../reactor/netty/http/server/HttpTrafficHandler.java 81.04% <100%> (+0.25%) 44 <0> (ø) ⬇️
...eactor/netty/channel/ChannelOperationsHandler.java 69.57% <0%> (+0.67%) 64% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 423760f...4e1c74d. Read the comment docs.

@violetagg violetagg merged commit 4e1c74d into master Nov 27, 2018
@violetagg violetagg deleted the issue-525 branch November 27, 2018 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants