Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override reactor.netty.http.HttpDecoderSpec methods to keep compatibility in 0.8.x #709

Merged
merged 1 commit into from Apr 9, 2019

Conversation

violetagg
Copy link
Member

This change is only for 0.8.x it will not be ported to 0.9.x

@violetagg violetagg added this to the 0.8.7.RELEASE milestone Apr 9, 2019
@smaldini
Copy link
Contributor

smaldini commented Apr 9, 2019

The pr targets master ?

@codecov-io
Copy link

codecov-io commented Apr 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (0.8.x@cdf3a16). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             0.8.x     #709   +/-   ##
========================================
  Coverage         ?   66.05%           
  Complexity       ?     1494           
========================================
  Files            ?      129           
  Lines            ?     6975           
  Branches         ?      952           
========================================
  Hits             ?     4607           
  Misses           ?     1866           
  Partials         ?      502
Impacted Files Coverage Δ Complexity Δ
...ctor/netty/http/server/HttpRequestDecoderSpec.java 100% <100%> (ø) 9 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdf3a16...f526c27. Read the comment docs.

@violetagg violetagg changed the base branch from master to 0.8.x April 9, 2019 18:50
@violetagg violetagg merged commit f526c27 into 0.8.x Apr 9, 2019
@violetagg violetagg deleted the http_request_decoder branch April 9, 2019 18:54
violetagg added a commit that referenced this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants