Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#533 drafts receiveCloseStatus method #815

Merged
merged 1 commit into from Sep 1, 2019
Merged

Conversation

OlegDokuka
Copy link
Contributor

This PR provides receiveCloseStatus for WebSocketInbound

@codecov-io
Copy link

codecov-io commented Aug 15, 2019

Codecov Report

Merging #815 into master will increase coverage by 0.08%.
The diff coverage is 95.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #815      +/-   ##
============================================
+ Coverage     67.07%   67.16%   +0.08%     
- Complexity     1436     1440       +4     
============================================
  Files           137      137              
  Lines          6725     6743      +18     
  Branches        864      864              
============================================
+ Hits           4511     4529      +18     
+ Misses         1756     1755       -1     
- Partials        458      459       +1
Impacted Files Coverage Δ Complexity Δ
...reactor/netty/http/websocket/WebsocketInbound.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...r/netty/http/client/WebsocketClientOperations.java 72.82% <100%> (+3.77%) 22 <1> (+2) ⬆️
...r/netty/http/server/WebsocketServerOperations.java 66.3% <92.85%> (+2.88%) 22 <3> (+3) ⬆️
...eactor/netty/http/client/HttpClientOperations.java 64.22% <0%> (-0.88%) 71% <0%> (-1%)
...c/main/java/reactor/netty/channel/FluxReceive.java 77.5% <0%> (ø) 62% <0%> (ø) ⬇️
...ctor/netty/resources/PooledConnectionProvider.java 81.88% <0%> (+0.78%) 25% <0%> (ø) ⬇️
.../java/reactor/netty/channel/ChannelOperations.java 92.74% <0%> (+0.8%) 59% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab4470...51a897d. Read the comment docs.

@violetagg violetagg added this to the 0.9.0.M4 milestone Aug 27, 2019
Copy link
Member

@violetagg violetagg left a comment

@smaldini
Copy link
Contributor

I think the event should be sent in these 4 places before the writeAndFlush in the protected CLOSE_SENT.getAndSet(this, 1) == 0) path.

Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@violetagg violetagg merged commit 344db30 into reactor:master Sep 1, 2019
@violetagg
Copy link
Member

I changed the title of the commit with this 78950ac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants