New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#533 drafts receiveCloseStatus
method
#815
Conversation
Codecov Report
@@ Coverage Diff @@
## master #815 +/- ##
============================================
+ Coverage 67.07% 67.16% +0.08%
- Complexity 1436 1440 +4
============================================
Files 137 137
Lines 6725 6743 +18
Branches 864 864
============================================
+ Hits 4511 4529 +18
+ Misses 1756 1755 -1
- Partials 458 459 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OlegDokuka @smaldini I think that the event should be emitted when the close frame is sent i.e.
For the client:
https://github.com/reactor/reactor-netty/blob/master/src/main/java/reactor/netty/http/client/WebsocketClientOperations.java#L206
https://github.com/reactor/reactor-netty/blob/master/src/main/java/reactor/netty/http/client/WebsocketClientOperations.java#L223
For the server:
https://github.com/reactor/reactor-netty/blob/master/src/main/java/reactor/netty/http/server/WebsocketServerOperations.java#L193
https://github.com/reactor/reactor-netty/blob/master/src/main/java/reactor/netty/http/server/WebsocketServerOperations.java#L211
I think the event should be sent in these 4 places before the writeAndFlush in the protected |
src/main/java/reactor/netty/http/server/WebsocketServerOperations.java
Outdated
Show resolved
Hide resolved
src/main/java/reactor/netty/http/server/WebsocketServerOperations.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I changed the title of the commit with this 78950ac |
This PR provides
receiveCloseStatus
forWebSocketInbound