Update Netty version to 4.1.41.Final #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please wait with this as there is a new release 4.1.41.Final |
Adapt to a change in Netty connection pool netty/netty#9542
violetagg
force-pushed
the
netty-4_1_40
branch
from
3573e11
to
4410e7e
Compare
violetagg
changed the title
|
UDP test fails with both 4.1.40.Final and 4.1.41.Final |
smaldini
approved these changes
Sep 23, 2019
|
#844 is still not resolved |
|
is there any chance to update directly to netty 4.1.42 ... needed to see netty/netty#9571 included, as this exposes a security issue |
|
(NB: as of today the UDP issue with epoll is still not resolved in |
|
Looking at this fix I wonder abuot the AttributeKey - it feels like this is only checking if the key has been ever used in "any pool". I suspect the intent was to check if the pool key is currently set on the channel ? |
smaldini
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to a change in Netty connection pool
netty/netty#9542