Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #865 Remove HttpToH2Operations in favour of Http2StreamFrameToHttpObjectCodec #874

Merged
merged 1 commit into from Oct 23, 2019

Conversation

violetagg
Copy link
Member

Http2StreamFrameToHttpObjectCodec is invoked after Http2StreamBridgeHandler
and before ChannelOperationsHandler.
When the message is delivered to Http*Operations class it is already HttpObject

…pObjectCodec

Http2StreamFrameToHttpObjectCodec is invoked after Http2StreamBridgeHandler
and before ChannelOperationsHandler.
When the message is delivered to Http*Operations class it is already HttpObject
@violetagg violetagg added this to the 0.8.13.RELEASE milestone Oct 23, 2019
@codecov-io
Copy link

codecov-io commented Oct 23, 2019

Codecov Report

Merging #874 into 0.8.x will increase coverage by 0.19%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##              0.8.x     #874      +/-   ##
============================================
+ Coverage     66.22%   66.42%   +0.19%     
+ Complexity     1393     1392       -1     
============================================
  Files           134      133       -1     
  Lines          6516     6495      -21     
  Branches        855      852       -3     
============================================
- Hits           4315     4314       -1     
+ Misses         1746     1726      -20     
  Partials        455      455
Impacted Files Coverage Δ Complexity Δ
...eactor/netty/http/server/HttpServerOperations.java 71.18% <0%> (-0.92%) 63 <0> (ø)
...or/netty/http/server/Http2StreamBridgeHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...eactor/netty/channel/ChannelOperationsHandler.java 79.62% <0%> (-1.86%) 11% <0%> (-1%)
...ctor/netty/resources/PooledConnectionProvider.java 79.56% <0%> (ø) 21% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd4047...27956e2. Read the comment docs.

@violetagg violetagg merged commit 27956e2 into 0.8.x Oct 23, 2019
@violetagg violetagg deleted the issue-865 branch October 23, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants