Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency to reactor-core should be api instead of implementation #107

Closed
ericbottard opened this issue Oct 26, 2020 · 3 comments · Fixed by #115
Closed

dependency to reactor-core should be api instead of implementation #107

ericbottard opened this issue Oct 26, 2020 · 3 comments · Fixed by #115
Assignees
@ericbottard
Labels
type/chore A task not related to code (build, formatting, process, ...)
Milestone
0.1.11.RELEASE

Comments

@ericbottard
Copy link
Contributor

This translated to runtime in maven POM instead of compile.
@ericbottard ericbottard added this to the 0.1.8.RELEASE milestone Oct 26, 2020
@reactorbot reactorbot added the ❓need-triage This issue needs triage, hasn't been looked at by a team member yet label Oct 26, 2020
@violetagg
Copy link
Member

@ericbottard Does this mean that reactor pool can run with whatever version is reactor-core?
Does this mean that if an API is deprecated in reactor core, reactor pool will continue to use this deprecated API so that it can run with every version of reactor core?

@ericbottard
Copy link
Contributor Author

ericbottard commented Oct 26, 2020 •
edited

Does this mean that reactor pool can run with whatever version is reactor-core?

no

Does this mean that if an API is deprecated in reactor core, reactor pool will continue to use this deprecated API

I don't know

This issue is about the fact that reactor-core types leak in the signatures of reactor-pool, so should be marked API, not implementation (which in practice doesn't change much because of course some project using r-pool uses reactor-core, but this is to be 100% correct)

@simonbasle simonbasle added status/need-investigation This needs more in-depth investigation type/chore A task not related to code (build, formatting, process, ...) and removed ❓need-triage This issue needs triage, hasn't been looked at by a team member yet labels Jan 8, 2021
ericbottard added a commit that referenced this issue Jan 11, 2021
@ericbottard
fix #107 dependency to core should use api
4c6d369 
This is because types from reactor-code leak in the signature of
reactor-pool, so should be marked as API.
As a consequence, the published pom will use compile instead of
runtime.
@simonbasle simonbasle removed the status/need-investigation This needs more in-depth investigation label Apr 15, 2021
@simonbasle
Copy link
Member

(to clarify, currently runtime scope is produced in the pom, this change will turn that into compile scope in the pom)

@simonbasle simonbasle linked a pull request Apr 15, 2021 that will close this issue
Use api dependency for core, ie compile scope in pom #115
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericbottard ericbottard

Labels
type/chore A task not related to code (build, formatting, process, ...)
Projects
None yet
Milestone
0.1.11.RELEASE
Development

Successfully merging a pull request may close this issue.

Use api dependency for core, ie compile scope in pom reactor/reactor-pool
4 participants
@ericbottard @violetagg @simonbasle @reactorbot