fix #51 Expose PoolConfig, rework PoolBuilder with factory #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
============================================
- Coverage 84.68% 83.66% -1.02%
- Complexity 113 124 +11
============================================
Files 11 12 +1
Lines 457 502 +45
Branches 67 67
============================================
+ Hits 387 420 +33
- Misses 44 55 +11
- Partials 26 27 +1
Continue to review full report at Codecov.
|
|
@nebhale can you have a look as well? good preview of the capacity for extending the builder with a custom configuration type is displayed in the test: https://github.com/reactor/reactor-pool/pull/55/files#diff-69a164d236f7941f6d8810aa3ebc0498R112 |
This commit heavily reworks how the PoolBuilder is producing a PoolConfig (internally) and then a concrete Pool instance. The goal is to open the builder for cases where implementations would be provided by external projects (eg. a netty event-loop aware implementation for a project that pools netty connections). One can pass a factory Function to the builder to create such a custom pool, possibly also switching the builder to a custom type of configuration beforehand. As a result, the DefaultPoolConfig has now been extracted as PoolConfig and made public. As a shorthand for the `build(Function)` that produces reactor-pool vanilla implementations, we now expose `lifo()` and `fifo()`, which are now the two out-of-the-box provided flavors.
simonbasle
force-pushed
the
51-poolBuilderAndConfigCustomization
branch
from
e04eda5
to
e525c3f
Compare
|
@violetagg @smaldini we could change the |
PoolConfig is now an interface, with a DefaultPoolConfig implementation that external pools can extend. acquisitionScheduler denotes a thread-determinism, but not all pool implementations are required to have such determinism. If they do, and the scheduler is set (to something other than immediate), then they MUST use this Scheduler.
bsideup
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit heavily reworks how the PoolBuilder is producing a PoolConfig
(internally) and then a concrete Pool instance.
The goal is to open the builder for cases where implementations would be
provided by external projects (eg. a netty event-loop aware implementation
for a project that pools netty connections).
One can pass a factory Function to the builder to create such a custom
pool, possibly also switching the builder to a custom type of configuration
beforehand. As a result, the DefaultPoolConfig has now been extracted as
PoolConfig and made public.
As a shorthand for the
build(Function)that produces reactor-pool vanillaimplementations, we now expose
lifo()andfifo(), which are now the two out-of-the-box provided flavors.