Skip to content

Commit

Permalink
Log error instead of propagating
Browse files Browse the repository at this point in the history
Could be useful if channel closing was idempotent, or at least caller
could know close/abort has already been called.
  • Loading branch information
acogoluegnes committed Apr 4, 2018
1 parent e89f912 commit 053b2f0
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/main/java/reactor/rabbitmq/Receiver.java
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,10 @@ public Flux<AcknowledgableDelivery> consumeManualAck(final String queue, Consume
channel.close();
}
} catch (TimeoutException | IOException e) {
throw new ReactorRabbitMqException(e);
// Not sure what to do, not much we can do,
// logging should be enough.
// Maybe one good reason to introduce an exception handler to choose more easily.
LOGGER.warn("Error while closing channel: " + e.getMessage());
}
}
});
Expand Down

0 comments on commit 053b2f0

Please sign in to comment.