Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an HttpCodec #53

Closed
jbrisbin opened this issue May 21, 2013 · 1 comment
Closed

Create an HttpCodec #53

jbrisbin opened this issue May 21, 2013 · 1 comment
Assignees

Comments

@jbrisbin
Copy link

I already have some code from an earlier version of Reactor that uses the Apache Commons httpcomponents core classes for doing HTTP parsing. It's actually quite straightforward and would be an easy way to get HTTP support on top of a raw TCP Reactor.

I also have some custom parsing code that has no dependencies on anything but the JDK. That also might be useful in case the user decided they didn't want to depend on the httpcomponents library. Making the HttpCodec pluggable, then, would allow different parsing implementations to be plugged in, depending on the use case.

If the HTTP parsing classes in Jetty or Tomcat were usable directly, we could also provide implementations that used those classes in case the deployment platform was already one of those servers. I haven't looked to see if this is possible yet, but it would be interesting to find that out.

@jbrisbin
Copy link
Author

jbrisbin commented Jun 4, 2013

Going to close this particular issue as it's been obsoleted by recent changes in reactor-tcp. We should create a new ticket for HTTP support that is more than just a codec.

@jbrisbin jbrisbin closed this as completed Jun 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant