[WIN32SS][FONT] Fix ntmCellHeight value to usWinAscent + usWinDescent #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BEFORE: |
learn-more
approved these changes
Nov 4, 2018
JoachimHenze
added a commit
that referenced
this pull request
Jan 1, 2021
…ment This commit deals with the following tickets: CORE-14994 "Spotify 1.0.29.92 has no icons on the buttons" which regressed by 0.4.10-dev-466-g 35f62fc CORE-15166 "Media Player Classic HomeCinema MPC HC 1.7.13 'elapsed time' in status bar uses incredibly tiny font" which regressed by 0.4.10-dev-466-g 35f62fc CORE-15303 "Firefox 28 does not longer show the checkmarks in the menubar" which regressed by 0.4.10-dev-466-g 35f62fc CORE-16125 "Marlett, the 'top-right-closing-x' drawing regressed" which regressed in master by 0.4.13-dev-110-g 19fc941 (in older releases by different commits) --------------- The fix that manages to fix them all is a backport of the code-base that evolved up to 0.4.12-release-24-g4572c75. This was the source of porting. *Before* the fix I found the following state for 0.4.11-release-39-gdeae917 by testing: CORE-14994 ok CORE-15166 ok CORE-15303 ok CORE-16125 affected *Before* the fix I found the following state for 0.4.10-release-48-g72a4ecb by testing: CORE-14994 affected CORE-15166 affected CORE-15303 affected CORE-16125 ok So the before-state was kind of exclusive-OR. *After* the fix all of the mentioned tickets are fixed for releases/0.4.10 and releases/0.4.11 Ftr: 0.4.12-release-24-g4572c75 had all 4 tickets fixed, because it did receive the needed patches beforehand. 0.4.9-release-56-g9be0765 had all 4 tickets fixed, because it was never hit yet by the guilty commits in master branch. It does not heavily need those fixes yet therefore. And last but not least, the backport to releases/0.4.10 will also inherently contain the fix for CORE-15331 "[WIN32SS][FONT] Fix NEWTEXTMETRIC.ntmCellHeight value" (which was already fixed in initial releases/0.4.11) In sum this backport contains the following commits (at least): 0.4.13-dev-483-g 641a0ea (#1670) CORE-14994 == 0.4.12-RC-38-g d5c85cd 0.4.13-dev-110-g 19fc941 (#1535) CORE-15303 == 0.4.12-RC-16-g e1ac9dc 0.4.12-RC-43-g 6f651b6 CORE-16125 (please note, that this is an interim solution and NOT yet the final master-fix of 0.4.13-dev-699-g b8383b4 which would have fixed that as well) 0.4.11-dev-914-g 88ddb37 (#1093) CORE-15166 0.4.11-dev-656-g 7f679a1 (#1010) CORE-15331 Porting any of those fixes on its own is dangerous, only their combination leads to tolerable results.
JoachimHenze
added a commit
that referenced
this pull request
Jan 1, 2021
…ment This commit deals with the following tickets: CORE-14994 "Spotify 1.0.29.92 has no icons on the buttons" which regressed by 0.4.10-dev-466-g 35f62fc CORE-15166 "Media Player Classic HomeCinema MPC HC 1.7.13 'elapsed time' in status bar uses incredibly tiny font" which regressed by 0.4.10-dev-466-g 35f62fc CORE-15303 "Firefox 28 does not longer show the checkmarks in the menubar" which regressed by 0.4.10-dev-466-g 35f62fc CORE-16125 "Marlett, the 'top-right-closing-x' drawing regressed" which regressed in master by 0.4.13-dev-110-g 19fc941 (in older releases by different commits) --------------- The fix that manages to fix them all is a backport of the code-base that evolved up to 0.4.12-release-24-g4572c75. This was the source of porting. *Before* the fix I found the following state for 0.4.11-release-39-gdeae917 by testing: CORE-14994 ok CORE-15166 ok CORE-15303 ok CORE-16125 affected *Before* the fix I found the following state for 0.4.10-release-48-g72a4ecb by testing: CORE-14994 affected CORE-15166 affected CORE-15303 affected CORE-16125 ok So the before-state was kind of exclusive-OR. *After* the fix all of the mentioned tickets are fixed for releases/0.4.10 and releases/0.4.11 Ftr: 0.4.12-release-24-g4572c75 had all 4 tickets fixed, because it did receive the needed patches beforehand. 0.4.9-release-56-g9be0765 had all 4 tickets fixed, because it was never hit yet by the guilty commits in master branch. It does not heavily need those fixes yet therefore. And last but not least, the backport to releases/0.4.10 will also inherently contain the fix for CORE-15331 "[WIN32SS][FONT] Fix NEWTEXTMETRIC.ntmCellHeight value" (which was already fixed in initial releases/0.4.11) In sum this backport contains the following commits (at least): 0.4.13-dev-483-g 641a0ea (#1670) CORE-14994 == 0.4.12-RC-38-g d5c85cd 0.4.13-dev-110-g 19fc941 (#1535) CORE-15303 == 0.4.12-RC-16-g e1ac9dc 0.4.12-RC-43-g 6f651b6 CORE-16125 (please note, that this is an interim solution and NOT yet the final master-fix of 0.4.13-dev-699-g b8383b4 which would have fixed that as well) 0.4.11-dev-914-g 88ddb37 (#1093) CORE-15166 0.4.11-dev-656-g 7f679a1 (#1010) CORE-15331 Porting any of those fixes on its own is dangerous, only their combination leads to tolerable results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR will reduce many failures in wine font testcase by fixing NEWTEXTMETRIC.ntmCellHeight value.
JIRA issue: CORE-15331