[WIN32SS][NTUSER] Fix message time

[katahiromz]

Purpose

This PR will fix CORE-15565 and make #1245 GetMessageTime testcase successful.
JIRA issue: CORE-15565

Proposed Changes

• Erase MsqCalculateMessageTime function.
• Use (DWORD)EngGetTickCount() instead.
• Ghosting is temporarily disabled.

[katahiromz]

That's correct! #1254 tests are successful!!

[katahiromz]

Okay, CORE-15565 is fixed!!!

[ThFabba]

Yeah this looks right to me. However let's make sure to have a Testbot run and compare Testman results so we don't get any regressions.

[spetreolle]

I ran a test build on the AHK test bot.
The 7-zip 9.20 installer gets an infinite loop of these messages:
(win32ss/user/ntuser/msgqueue.c:420) err: This Message Queue is in Destroy!
(win32ss/user/ntuser/msgqueue.c:1350) err: Post Msg; Thread or Q is Dead!

Build and results:
https://build.reactos.org/builders/Test%20KVM%20AHK/builds/7348
https://reactos.org/testman/compare.php?ids=65179

[spetreolle]

For more complete details on testman:
heres the comparison between the revision before your branch and the last run:
https://reactos.org/testman/compare.php?ids=65175,65199

[katahiromz]

I have tried tests (double checked).

1.install: 5 tests executed (0 marked as todo, 0 failures), 0 skipped.
err:(dll/win32/lsasrv/lsarpc.c:1452) LsapOpenDbObject(Accounts/S-1-5-21-410983899-1221649272-839906308-500) failed (Status 0xc0000034)
(win32ss/user/ntuser/winpos.c:3364) err: NtUserSetWindowPos bad window handle!
2.AddArchive: Test failed: Sent DOWN key to select the file, but got '0 object(s) selected', which could mean SysListView321 control was not focused on ReactOS when app started. ReactOS is slower than Windows. Active Wnd: 'C:\Program Files\7-Zip\AHK_Test\'.
Info: 2.AddArchive: Can NOT find 'C:\ReactOS\bin\Apps\Cap.exe'.
(win32ss/user/ntuser/input.c:509) err: Attach Allocated! ptiFrom 0xB0A58008  ptiTo 0xB0A59110 paiCount 1
(win32ss/user/ntuser/input.c:532) err: ptiFrom NOT Foreground
(win32ss/user/ntuser/input.c:565) err: ptiTo S Share count 2
(win32ss/user/ntuser/input.c:600) err: Attach Free! ptiFrom 0xB0A58008  ptiTo 0xB0A59110 paiCount 0
(win32ss/user/ntuser/input.c:614) err: ptiTo E Share count 1
Info: 2.AddArchive: SysListView321 control is focused now, lets send DOWN key.
2.AddArchive: Test failed: Sent DOWN key to select the file, but got '0 object(s) selected', but SysListView321 control WAS focused. Active Wnd: 'C:\Program Files\7-Zip\AHK_Test\'.
Info: 2.AddArchive: Can NOT find 'C:\ReactOS\bin\Apps\Cap.exe'.
2.AddArchive: 4 tests executed (0 marked as todo, 2 failures), 1 skipped.

Not reproduced for me. Was it an accidential error?

[katahiromz]

Now ghosting is disabled.

[katahiromz]

https://reactos.org/testman/compare.php?ids=66871,66868
https://reactos.org/testman/compare.php?ids=66873,66868

I think error increasing is because of Can NOT find 'C:\ReactOS\bin\Apps\Cap.exe'. What does this mean? it was a screen capture program.

[katahiromz]

usurp in IRC room: @katayama Hirofumi MZ regarding PR #1259, the 2 tests, Java and vb6 don't show the expected windows. its random at least for Java*$

I will commit this PR 2 days later. Any objection?

[katahiromz]

Unpatched:
https://build.reactos.org/builders/Build%20GCCLin_x86/builds/24321
https://build.reactos.org/builders/Test%20KVM/builds/23192
Got Revision: 983cd57

PR #1259 test:
https://build.reactos.org/builders/Build%20GCCLin_x86/builds/24322
https://build.reactos.org/builders/Test%20KVM/builds/23193
Got Revision: 9f8f223

https://reactos.org/testman/compare.php?ids=66977,66978
@learn-more How do you think about this results?

[spetreolle]

Unpatched AHK run:
https://build.reactos.org/builders/Test%20KVM%20AHK/builds/8083
PR #1259 test on AHK:
https://build.reactos.org/builders/Test%20KVM%20AHK/builds/8087

https://reactos.org/testman/compare.php?ids=66975,66981

Many improvements @katahiromz

[learn-more]

user32:SwitchToThisWindow results seem better,
fonts are a bit worse but that seems unrelated?

[SergeGautherie]

Ghosting is temporarily disabled.

PR committed, Issue fixed.
What is the next step? A Jira issue, a GitHub PR, at least a // FIXME?