Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OLE32] Implement WS_EX_ACCEPTFILES #1403

Merged
merged 5 commits into from Mar 15, 2019
Merged

[OLE32] Implement WS_EX_ACCEPTFILES #1403

merged 5 commits into from Mar 15, 2019

Conversation

katahiromz
Copy link
Contributor

@katahiromz katahiromz commented Mar 9, 2019 •
edited

Purpose

The window that has WS_EX_ACCEPTFILES extended style, should pretend like a drop target that accepts CF_HDROP data. This PR will fix many bugs related to Drag & Drop.
JIRA issue: CORE-11238

TODO

  • Fix WM_COPYGLOBALDATA handling.
  • Fix the bmp-onto-WordPad problem.

@katahiromz katahiromz added the WIP label Mar 9, 2019
@tkreuzer tkreuzer added this to New PRs in ReactOS PRs Mar 10, 2019
@tkreuzer tkreuzer moved this from New PRs to WIP / Waiting on contributor in ReactOS PRs Mar 10, 2019
@katahiromz katahiromz removed the WIP label Mar 13, 2019
@katahiromz
Copy link
Contributor Author

katahiromz commented Mar 13, 2019 •
edited

https://jira.reactos.org/secure/attachment/51920/51920_DnD-success.webm
Thank you @jimtabor !

@HBelusca
Copy link
Contributor

So, dropping files in the console should work now?

@katahiromz
Copy link
Contributor Author

katahiromz commented Mar 13, 2019 •
edited

Console works.
https://jira.reactos.org/secure/attachment/51921/51921_console-drop-success.webm

Dropped a bmp file onto notepad:
https://jira.reactos.org/secure/attachment/51925/51925_drop-bmp-on-notepad.webm

@katahiromz
Copy link
Contributor Author

katahiromz commented Mar 14, 2019 •
edited

Currently dropping a bmp file onto WordPad has a freezing problem.
The log: https://jira.reactos.org/secure/attachment/51926/bmp-on-wordpad-log.txt
Cc @jimtabor

@katahiromz katahiromz added the WIP label Mar 14, 2019
@HBelusca
Copy link
Contributor

https://jira.reactos.org/browse/CORE-14833 works now :)

@katahiromz
Copy link
Contributor Author

I found this bug is not OLE32's bug. DoDragDrop is correctly passed. I will force commit.

@katahiromz katahiromz merged commit 332ca5f into reactos:master Mar 15, 2019
ReactOS PRs automation moved this from WIP / Waiting on contributor to Done Mar 15, 2019
@katahiromz katahiromz deleted the implement-dnd branch March 15, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineKhaldi AmineKhaldi Awaiting requested review from AmineKhaldi

@HBelusca HBelusca Awaiting requested review from HBelusca

Assignees
No one assigned
Labels
None yet
Projects
ReactOS PRs
  
Done
Milestone
No milestone
2 participants
@katahiromz @HBelusca