New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of Utility Manager (Accessibility) #1608
Conversation
|
As per the documentation:
Either I am doing it wrong or it's the documentation that says it wrongly. If it's the latter is there an alternative way to catch the code value returned by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps, it is necessary to take information from the registry?: "hklm\software\microsoft\windows nt\currentversion\accessibility"
As said, this is an initial implementation of Utility Manager. Implementation of registry configuration handler will come later (see NOTES on commit files) as it'll take quite a couple of time to figure out the correct implementation. Thank you for pointing out the registry key though. This will help me know where are the values which Utility Manager manages stored. |
base/applications/utilman/process.c
Outdated
si.dwFlags = STARTF_USESHOWWINDOW; | ||
si.wShowWindow = SW_SHOWNORMAL; | ||
|
||
if (!CreateProcessW(NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for not always using ShellExecuteW
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be picky:
The OSK can be used also before logging in (in winlogon's secure desktop) and in other situations for example in Windows / NT installations where the shell (and thus, shell32) has not been installed yet.
CORE-15974
53cf783
to
b1ff230
Compare
* FALSE otherwise. | ||
* | ||
*/ | ||
BOOL CloseProcess(IN LPCWSTR lpProcessName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something to refactor on the next PR for this tool:
You can largely combine IsProcessRunning
and CloseProcess
, by creating one helper function that simply finds the process ID of the process you are interested, and returns that (or 0 if it's not found).
Then both functions do not need to walk the process list exactly the same way.
Implement a small helper, GetProcessID(), that will be used to return the process ID which we are interested in. This largely removes some duplicated code. The following patch addresses the Jansen's comment on reactos#1608 PR.
Implement a small helper, GetProcessID(), that will be used to return the process ID which we are interested in. This largely removes some duplicated code. The following patch addresses the Jansen's comment on reactos#1608 PR.
Implement a small helper, GetProcessID(), that will be used to return the process ID which we are interested in. This largely removes some duplicated code. The following patch addresses the Jansen's comment on reactos#1608 PR.
Implement a small helper, GetProcessID(), that will be used to return the process ID which we are interested in. This largely removes some duplicated code. The following patch addresses the Jansen's comment on reactos#1608 PR.
Implement a small helper, GetProcessID(), that will be used to return the process ID which we are interested in. This largely removes some duplicated code. The following patch addresses the Jansen's comment on reactos#1608 PR.
Implement a small helper, GetProcessID(), that will be used to return the process ID which we are interested in. This largely removes some duplicated code. The following patch addresses the Jansen's comment on reactos#1608 PR.
Implement a small helper, GetProcessID(), that will be used to return the process ID which we are interested in. This largely removes some duplicated code. The following patch addresses the Jansen's comment on reactos#1608 PR.
Implement a small helper, GetProcessID(), that will be used to return the process ID which we are interested in. This largely removes some duplicated code. The following patch addresses the Jansen's comment on #1608 PR.
Purpose
This is the implementation of Utility Manager. For people that don't remember what it is, it's a program to manage accessibility tools which it can be found on Windows XP and Server 2003. The basic functionality is already implemented therefore more has to come.
Presentation
URL Video: https://www.youtube.com/watch?v=6UCuiSpNAVg
JIRA
JIRA Issue: https://jira.reactos.org/browse/CORE-15974