[CPL][APPWIZ] Use display name for shortcut label #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HBelusca
reviewed
Jan 28, 2020
| @@ -176,6 +177,23 @@ BOOL IsInternetLocation(LPCWSTR pszLocation) | |||
| return (PathIsURLW(pszLocation) || wcsstr(pszLocation, L"www.") == pszLocation); | |||
| } | |||
|
|
|||
| void | |||
| DoConvertNameForFileSystem(LPWSTR szName) | |||
There was a problem hiding this comment.
What is the point of this function?
EDIT: OK Maybe I understand: is it just removing all invalid characters from the name?
There was a problem hiding this comment.
Actually it would be better to use the more complete PathCleanupSpec() function (that only takes UNICODE characters by the way), we have it implemented, and is documented:
https://docs.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-pathcleanupspec
There was a problem hiding this comment.
No, I can't agree. Windows actually deletes a colon of a drive label in this situation. Our PathCleanupSpec didn't implement PCS_REMOVEDCHAR yet.
There was a problem hiding this comment.
Added a comment.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
JIRA issue: CORE-16534
STEP 1: Right Click Desktop and Choose
New ==> New Link.STEP2: Type
C:\and ClickNext.STEP3: You will get display name.