Create .editorconfig #2528
Merged
Create .editorconfig #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HBelusca
reviewed
Apr 11, 2020
| indent_style = space | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [*.{json,yml,md}] |
There was a problem hiding this comment.
Do we use json/yml in our codebase?
There was a problem hiding this comment.
yml is used for appveyor, gitpod and travis, at least.
ThFabba
reviewed
Apr 11, 2020
| root = true | ||
|
|
||
| [*] | ||
| end_of_line = crlf |
There was a problem hiding this comment.
This is not accurate, most files should use native line endings. See .gitattributes.
There was a problem hiding this comment.
According to
https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#end_of_line
there is not yet a value to translate "native line endings"
so I will remove it from the editorconfig.
HBelusca
added a commit
that referenced
this pull request
Apr 11, 2020
According to https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#end_of_line there is not yet any value to translate "use the native end-of-line" from the VCS. So for the time being, let's follow the advice mentioned in the article: > if you want to use native line endings between different operating systems it is better not to set this option and leave that task to the VCS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add .editorconfig file to automate some files-params while coding