[NETSHELL] Remove erroneous DNS Server line and fix date/time format

[ghost]

Purpose

_ Current Network information does not rely on system / user settings for date and time formatting
_ Current Network information always insert a "blank" DNS server line before the actual one.

JIRA issue: CORE-16947

Proposed changes

_ Use correct formatting
_ Remove erroneous DNS line

[binarymaster]

There are two code chunks that are repeated. Please make a function for it.

[ghost]

@binarymaster : Thanks !

I was not able to reproduce locally the last comment. Committed on Git on your proposal.
All comments OK now. OK for merge ?

[binarymaster]

LGTM. Let's wait for some more reviews from others.

[binarymaster]

@KyleKatarn31 I fixed whitespace problems and squashed all changes into one commit. If you will need to update your code again, please do hard reset to my commit and continue your work from it.

I already did this yesterday, but you applied existing commits on top of it, so my fixes got broken again.

[ghost]

@KyleKatarn31 I fixed whitespace problems and squashed all changes into one commit. If you will need to update your code again, please do hard reset to my commit and continue your work from it.

I already did this yesterday, but you applied existing commits on top of it, so my fixes got broken again.

OK thanks ! I hope I won't have any additional change to apply :-)

[binarymaster]

OK thanks ! I hope I won't have any additional change to apply :-)

@KyleKatarn31 you ignored what I said earlier: #2655 (comment)

You rewrote my changes that already had _countof fixes and more: 522e140

[ghost]

OK thanks ! I hope I won't have any additional change to apply :-)

@KyleKatarn31 you ignored what I said earlier: #2655 (comment)

You rewrote my changes that already had _countof fixes and more: 522e140

I thought that I could finally use the explicit length since it's now basec on dynalloc. I'll rework again following the feedback from all of you. Thanks !

[ghost]

Fixed, tested, fully operative.
@HBelusca : is the implementation based CString as you requested ?
@learn-more : as code owner, do you approve current solution ?

[ghost]

Thanks !