[SNDREC32] Fix incorrect opaque text rendering #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Purpose - SNDREC32 currently use an ugly text rendering with incorrect OPAQUE background to white, while DC is set to be transparent.
katahiromz
approved these changes
May 9, 2020
learn-more
approved these changes
May 9, 2020
sdever
approved these changes
May 9, 2020
|
Thanks ! |
ghost
deleted the
JoachimHenze
added a commit
that referenced
this pull request
Oct 16, 2021
…RE-17815 and several PRs) My main motivation was a fix for the bug CORE-17815 'Fix incorrect opaque text rendering' (#2760) which was unhidden by 0.4.12-dev-824-g d57f7be . That specific and most important fix was picked from 0.4.15-dev-190-g d839e3d We left out the additional WIN32SS-hardening in this context in the backport to older releases for now. Then I looked further in sndrec32 and compared each file of that module on master head with both: current 0.4.14RC and also current 0.4.7rls and found the rare situation that I liked each and every change within since 2017. Specifically this will also backport (#2754), and various translation PRs, whitespace-cleanup, and (for older releases than 0.4.14RC) it will also bring some x64-improvements. So I decided to take everything from current master head except the changes in CMakeLists.txt because that subset is applicable and a win for all ros releases down to 0.4.7.
JoachimHenze
added a commit
that referenced
this pull request
Jan 17, 2022
…RE-17815 and several PRs) My main motivation was a fix for the bug CORE-17815 'Fix incorrect opaque text rendering' (#2760) which was unhidden by 0.4.12-dev-824-g d57f7be . That specific and most important fix was picked from 0.4.15-dev-190-g d839e3d We left out the additional WIN32SS-hardening in this context in the backport to older releases for now. Then I looked further in sndrec32 and compared each file of that module on master head with both: current 0.4.14RC and also current 0.4.7rls and found the rare situation that I liked each and every change within since 2017. Specifically this will also backport (#2754), and various translation PRs, whitespace-cleanup, and (for older releases than 0.4.14RC) it will also bring some x64-improvements. So I decided to take everything from current master head except the changes in CMakeLists.txt because that subset is applicable and a win for all ros releases down to 0.4.7.
JoachimHenze
added a commit
that referenced
this pull request
Jan 17, 2022
…RE-17815 and several PRs) My main motivation was a fix for the bug CORE-17815 'Fix incorrect opaque text rendering' (#2760) which was unhidden by 0.4.12-dev-824-g d57f7be . That specific and most important fix was picked from 0.4.15-dev-190-g d839e3d We left out the additional WIN32SS-hardening in this context in the backport to older releases for now. Then I looked further in sndrec32 and compared each file of that module on master head with both: current 0.4.14RC and also current 0.4.7rls and found the rare situation that I liked each and every change within since 2017. Specifically this will also backport (#2754), and various translation PRs, whitespace-cleanup, and (for older releases than 0.4.14RC) it will also bring some x64-improvements. So I decided to take everything from current master head except the changes in CMakeLists.txt because that subset is applicable and a win for all ros releases down to 0.4.7.
JoachimHenze
added a commit
that referenced
this pull request
Jan 17, 2022
…RE-17815 and several PRs) My main motivation was a fix for the bug CORE-17815 'Fix incorrect opaque text rendering' (#2760) which was unhidden by 0.4.12-dev-824-g d57f7be . That specific and most important fix was picked from 0.4.15-dev-190-g d839e3d We left out the additional WIN32SS-hardening in this context in the backport to older releases for now. Then I looked further in sndrec32 and compared each file of that module on master head with both: current 0.4.14RC and also current 0.4.7rls and found the rare situation that I liked each and every change within since 2017. Specifically this will also backport (#2754), and various translation PRs, whitespace-cleanup, and (for older releases than 0.4.14RC) it will also bring some x64-improvements. So I decided to take everything from current master head except the changes in CMakeLists.txt because that subset is applicable and a win for all ros releases down to 0.4.7.
JoachimHenze
added a commit
that referenced
this pull request
Jan 17, 2022
…RE-17815 and several PRs) My main motivation was a fix for the bug CORE-17815 'Fix incorrect opaque text rendering' (#2760) which was unhidden by 0.4.12-dev-824-g d57f7be . That specific and most important fix was picked from 0.4.15-dev-190-g d839e3d We left out the additional WIN32SS-hardening in this context in the backport to older releases for now. Then I looked further in sndrec32 and compared each file of that module on master head with both: current 0.4.14RC and also current 0.4.7rls and found the rare situation that I liked each and every change within since 2017. Specifically this will also backport (#2754), and various translation PRs, whitespace-cleanup, and (for older releases than 0.4.14RC) it will also bring some x64-improvements. So I decided to take everything from current master head except the changes in CMakeLists.txt because that subset is applicable and a win for all ros releases down to 0.4.7.
JoachimHenze
added a commit
that referenced
this pull request
Jan 17, 2022
…E-17815 and several PRs) My main motivation was a fix for the bug CORE-17815 'Fix incorrect opaque text rendering' (#2760) which was unhidden by 0.4.12-dev-824-g d57f7be . That specific and most important fix was picked from 0.4.15-dev-190-g d839e3d We left out the additional WIN32SS-hardening in this context in the backport to older releases for now. Then I looked further in sndrec32 and compared each file of that module on master head with both: current 0.4.14RC and also current 0.4.7rls and found the rare situation that I liked each and every change within since 2017. Specifically this will also backport (#2754), and various translation PRs, whitespace-cleanup, and (for older releases than 0.4.14RC) it will also bring some x64-improvements. So I decided to take everything from current master head except the changes in CMakeLists.txt because that subset is applicable and a win for all ros releases down to 0.4.7.
JoachimHenze
added a commit
that referenced
this pull request
Jan 17, 2022
…E-17815 and several PRs) My main motivation was a fix for the bug CORE-17815 'Fix incorrect opaque text rendering' (#2760) which was unhidden by 0.4.12-dev-824-g d57f7be . That specific and most important fix was picked from 0.4.15-dev-190-g d839e3d We left out the additional WIN32SS-hardening in this context in the backport to older releases for now. Then I looked further in sndrec32 and compared each file of that module on master head with both: current 0.4.14RC and also current 0.4.7rls and found the rare situation that I liked each and every change within since 2017. Specifically this will also backport (#2754), and various translation PRs, whitespace-cleanup, and (for older releases than 0.4.14RC) it will also bring some x64-improvements. So I decided to take everything from current master head except the changes in CMakeLists.txt because that subset is applicable and a win for all ros releases down to 0.4.7.
JoachimHenze
added a commit
that referenced
this pull request
Jan 17, 2022
…E-17815 and several PRs) My main motivation was a fix for the bug CORE-17815 'Fix incorrect opaque text rendering' (#2760) which was unhidden by 0.4.12-dev-824-g d57f7be . That specific and most important fix was picked from 0.4.15-dev-190-g d839e3d We left out the additional WIN32SS-hardening in this context in the backport to older releases for now. Then I looked further in sndrec32 and compared each file of that module on master head with both: current 0.4.14RC and also current 0.4.7rls and found the rare situation that I liked each and every change within since 2017. Specifically this will also backport (#2754), and various translation PRs, whitespace-cleanup, and (for older releases than 0.4.14RC) it will also bring some x64-improvements. So I decided to take everything from current master head except the changes in CMakeLists.txt and some hebrew RTL addition because that subset is applicable and a win for all ros releases down to 0.4.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Proposed changes
Remove "Opaque" parameter so that the transparency can be correctly used.