[NTOS:PNP] Implement PlugPlayControlStartDevice control class and use it #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Tested, achieved two improvements, one remains the same :)
✔️ Tested on VirtualBox with LiveCD - ISAPNP read data port now appears in Device Manager.
✔️ Networking works now both in LiveCD and in 2nd stage setup.
✖️ PS/2 keyboard and mouse in 3rd stage with Standard HAL still not working for me, the same error code in Device Manager.
HBelusca
reviewed
Mar 14, 2021
| Status = NtPlugPlayControl(PlugPlayControlDeviceStatus, &PlugPlayData, sizeof(PlugPlayData)); | ||
| if (NT_SUCCESS(Status)) | ||
| { | ||
| return (_Bool)((PlugPlayData.DeviceStatus & DN_DRIVER_LOADED) && |
There was a problem hiding this comment.
Suggested change
| return (_Bool)((PlugPlayData.DeviceStatus & DN_DRIVER_LOADED) && | |
| return (BOOLEAN)((PlugPlayData.DeviceStatus & DN_DRIVER_LOADED) && |
(you can use the same return type as the function.)
Extravert-ir
force-pushed
the
pnp_control_start
branch
2 times, most recently
from
f82c761
to
022499a
Compare
…l class PlugPlayControlResetDevice shares the input structure with several other control classes. Source: ProcessHacker sources https://github.com/processhacker/phnt/blob/e9c8121f41b00cd24e31eb466c9795785096b764/ntpnpapi.h
This control class is triggered when a driver is being installed for a non-critical device. The driver info should already be in the registry so we just need to push the device through the state graph Meanwhile, combine the code for similar control classes into PiControlSyncDeviceAction routine CORE-17463 CORE-17490
Instead of PlugPlayControlResetDevice, PlugPlayControlStartDevice should be used for a newly installed device. For usetup, add a device status check before starting attempt, so we're not touching devices which are already started. CORE-17463 CORE-17490
Extravert-ir
force-pushed
the
pnp_control_start
branch
from
022499a
to
abbc5ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another action for starting devices after usermode PnP service enables the driver for it.
PlugPlayControlResetDeviceis wrong in this case, because it returns the device node back toDeviceNodeUninitializedstate, which is an overkill here (initialization phase is completed successfully, no need to repeat it)Should fix: CORE-17490, CORE-17463