Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMAKE][BOOTDATA] Fix root CA certificates for Live CD #3930

Merged
merged 1 commit into from Aug 30, 2021
Merged

[CMAKE][BOOTDATA] Fix root CA certificates for Live CD #3930

merged 1 commit into from Aug 30, 2021

Conversation

julcar
Copy link
Contributor

@julcar julcar commented Aug 24, 2021

Purpose

Starting with commit 6158207, caroots.inf is no longer added to LiveCD image builds, this turns into a trouble when a LiveCD user tries to load TLS/SSL sites using our built-in secure channel, and what they find is that the CA chains cannot be generated and thus failing.

JIRA issue: CORE-17739

Proposed changes

  1. Add caroots.inf contents directly to the registry hives when building the LiveCD ISO.
  2. Do not include the file caroots.inf in the LiveCD ISO, because it is added directly into the registry.

@binarymaster binarymaster added the bugfix For bugfix PRs. label Aug 24, 2021
@binarymaster binarymaster added this to New PRs in ReactOS PRs via automation Aug 24, 2021
@binarymaster binarymaster changed the title Livecd caroots [CMAKE][BOOTDATA] Fix root CA certificates for Live CD Aug 24, 2021
@binarymaster
[CMAKE][BOOTDATA] Fix root CA certificates for Live CD (reactos#3930)
f677316 
This fixes regression introduced in 6158207.

CORE-17739 CORE-17735
binarymaster
binarymaster approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@binarymaster binarymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. 👍 I've squashed your changes into single commit removing useless merge commits from your branch 😉

ReactOS PRs automation moved this from New PRs to Approved by reviewers Aug 24, 2021
@JoachimHenze JoachimHenze merged commit 2268b33 into reactos:master Aug 30, 2021
ReactOS PRs automation moved this from Approved by reviewers to Done Aug 30, 2021
JoachimHenze pushed a commit that referenced this pull request Aug 30, 2021
@JoachimHenze
[0.4.14][CMAKE][BOOTDATA] Fix LiveCD does not import caroots.inf into…
3c1d046 
… registry CORE-17739 CORE-17735 (#3930)

It regressed by 0.4.9-dev-82-g 6158207

fix picked from 0.4.15-dev-3082-g 2268b33)
@julcar julcar deleted the livecd_caroots branch November 20, 2021 01:25
@julcar julcar restored the livecd_caroots branch November 20, 2021 01:26
@julcar julcar deleted the livecd_caroots branch November 20, 2021 01:27
JoachimHenze added a commit that referenced this pull request Jan 21, 2022
@JoachimHenze
[0.4.13][CMAKE][BOOTDATA] Fix LiveCD does not import caroots.inf into…
1e875d6 
… registry CORE-17739 CORE-17735 (#3930)

It regressed by 0.4.9-dev-82-g 6158207

fix picked from 0.4.15-dev-3082-g 2268b33
JoachimHenze added a commit that referenced this pull request Jan 21, 2022
@JoachimHenze
[0.4.12][CMAKE][BOOTDATA] Fix LiveCD does not import caroots.inf into…
119c7b0 
… registry CORE-17739 CORE-17735 (#3930)

It regressed by 0.4.9-dev-82-g 6158207

fix picked from 0.4.15-dev-3082-g 2268b33
JoachimHenze added a commit that referenced this pull request Jan 21, 2022
@JoachimHenze
[0.4.11][CMAKE][BOOTDATA] Fix LiveCD does not import caroots.inf into…
72cfd7d 
… registry CORE-17739 CORE-17735 (#3930)

It regressed by 0.4.9-dev-82-g 6158207

fix picked from 0.4.15-dev-3082-g 2268b33
JoachimHenze added a commit that referenced this pull request Jan 21, 2022
@JoachimHenze
[0.4.10][CMAKE][BOOTDATA] Fix LiveCD does not import caroots.inf into…
da60f70 
… registry CORE-17739 CORE-17735 (#3930)

It regressed by 0.4.9-dev-82-g 6158207

fix picked from 0.4.15-dev-3082-g 2268b33
JoachimHenze added a commit that referenced this pull request Jan 21, 2022
@JoachimHenze
[0.4.9][CMAKE][BOOTDATA] Fix LiveCD does not import caroots.inf into …
61fa5ea 
…registry CORE-17739 CORE-17735 (#3930)

It regressed by 0.4.9-dev-82-g 6158207

fix picked from 0.4.15-dev-3082-g 2268b33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binarymaster binarymaster binarymaster approved these changes

@learn-more learn-more learn-more approved these changes

@HBelusca HBelusca HBelusca approved these changes

@ThFabba ThFabba Awaiting requested review from ThFabba

Assignees
No one assigned
Labels
bugfix For bugfix PRs.
Projects
ReactOS PRs
  
Done
Milestone
No milestone
5 participants
@julcar @binarymaster @learn-more @HBelusca @JoachimHenze