Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NETSTAT] Fixes coverity #1477187 "Double free" #4069

Merged
merged 1 commit into from Oct 28, 2021
Merged

[NETSTAT] Fixes coverity #1477187 "Double free" #4069

merged 1 commit into from Oct 28, 2021

Conversation

omoiti
Copy link
Contributor

@omoiti omoiti commented Oct 25, 2021 •
edited by JoachimHenze

Within the current ShowTcpTable function logic, tcpTable would be freed twice. This pull request removes the second tcpTable free and should fix coverity #1477187.

JIRA issue: CORE-17831

@binarymaster binarymaster added the bugfix For bugfix PRs. label Oct 25, 2021
@binarymaster binarymaster added this to New PRs in ReactOS PRs via automation Oct 25, 2021
@learn-more
Copy link
Member

Hello,
Thanks for your interest in ReactOS!
We ask our contributors to use their full name when committing.
Please amend your commit with your full name, and update this PR.

To change this for future PR's, you can update it for globally (for the system):

git config --global user.name "Your Name"
git config --global user.email you@example.com

Or just for the current repository:

git config user.name "Your Name"
git config user.email you@example.com

Regards,

SergeGautherie
SergeGautherie approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@SergeGautherie SergeGautherie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was wrongly added by b695971.

ReactOS PRs automation moved this from New PRs to Approved by reviewers Oct 25, 2021
@binarymaster binarymaster added manual merging Requires manual merging due to an unclean history no squash merge Author has no full name in GitHub profile, either merge by rebase or manually and removed manual merging Requires manual merging due to an unclean history labels Oct 26, 2021
@omoiti @binarymaster
[NETSTAT] Fix coverity #1477187 "Double free" (#4069)
0e75fc9 
Within the current ShowTcpTable function logic, tcpTable would be freed twice.
The bug was introduced in b695971.

Remove the second tcpTable free and fix coverity #1477187. CORE-17831
@binarymaster binarymaster merged commit 0e75fc9 into reactos:master Oct 28, 2021
ReactOS PRs automation moved this from Approved by reviewers to Done Oct 28, 2021
JoachimHenze added a commit that referenced this pull request Oct 28, 2021
@JoachimHenze
[0.4.14][NETSTAT] Fix coverity #1477187 "Double free" (#4069) CORE-17831
5e81087 
Within the current ShowTcpTable function logic, tcpTable would be freed twice.
The bug was introduced in 0.4.13-dev-579-g b695971

Remove the second tcpTable free and fix coverity #1477187.

fix picked from 0.4.15-dev-3338-g 0e75fc9
JoachimHenze added a commit that referenced this pull request Nov 15, 2021
@JoachimHenze
[0.4.13][NETSTAT] Fix coverity #1477187 "Double free" (#4069) CORE-17831
f9841ef 
Within the current ShowTcpTable function logic, tcpTable would be freed twice.
The bug was introduced in 0.4.13-dev-579-g b695971

Remove the second tcpTable free and fix coverity #1477187.

fix picked from 0.4.15-dev-3338-g 0e75fc9
JoachimHenze added a commit that referenced this pull request Jul 5, 2023
@JoachimHenze
[0.4.12][NETSTAT] Picky Backports up to master-state 2023-07-06
0997d7d 
0.4.15-dev-6256-g 8ef47d2 [NETSTAT] Optimize a bit (#5405)
partially 0.4.15-dev-6245-g 5ee97b9 [NETSTAT] -b flag implies -o flag on Windows XP/2003. CORE-19006 (#5377)
partially 0.4.15-dev-6211-g 40864bc [NETSTAT] Fix crash when parsing the protocol CORE-19005 (#5363)
0.4.15-dev-3338-g 0e75fc9 [NETSTAT] Fix coverity #1477187 "Double free" (#4069) CORE-17831 [I ported this double-free-fix earlier already into releases/0.4.13 & releases/0.4.14 and it didn't affect any older releases than that]
partially 0.4.14-dev-479-g 1fa2780 [NETSTAT] Fix output formats
0.4.13-dev-584-g 5e10c4e [NETSTAT] ShowUdpTable(): Fix "tcp" copypasta (#1699)
partially 0.4.13-dev-579-g b695971 [NETSTAT] Simplify some code
partially 0.4.13-dev-578-g ab7dc56 [NETSTAT] Formatting
partially 0.4.13-dev-519-g dda5ec4 [NETSTAT] Simplify DoFormatMessage() (just the changed retval)
JoachimHenze added a commit that referenced this pull request Jul 5, 2023
@JoachimHenze
[0.4.11][NETSTAT] Picky Backports up to master-state 2023-07-06
9f2f507 
0.4.15-dev-6256-g 8ef47d2 [NETSTAT] Optimize a bit (#5405)
partially 0.4.15-dev-6245-g 5ee97b9 [NETSTAT] -b flag implies -o flag on Windows XP/2003. CORE-19006 (#5377)
partially 0.4.15-dev-6211-g 40864bc [NETSTAT] Fix crash when parsing the protocol CORE-19005 (#5363)
0.4.15-dev-3338-g 0e75fc9 [NETSTAT] Fix coverity #1477187 "Double free" (#4069) CORE-17831 [I ported this double-free-fix earlier already into releases/0.4.13 & releases/0.4.14 and it didn't affect any older releases than that]
partially 0.4.14-dev-479-g 1fa2780 [NETSTAT] Fix output formats
0.4.13-dev-584-g 5e10c4e [NETSTAT] ShowUdpTable(): Fix "tcp" copypasta (#1699)
partially 0.4.13-dev-579-g b695971 [NETSTAT] Simplify some code
partially 0.4.13-dev-578-g ab7dc56 [NETSTAT] Formatting
partially 0.4.13-dev-519-g dda5ec4 [NETSTAT] Simplify DoFormatMessage() (just the changed retval)
JoachimHenze added a commit that referenced this pull request Jul 5, 2023
@JoachimHenze
[0.4.10][NETSTAT] Picky Backports up to master-state 2023-07-06
d85acd3 
0.4.15-dev-6256-g 8ef47d2 [NETSTAT] Optimize a bit (#5405)
partially 0.4.15-dev-6245-g 5ee97b9 [NETSTAT] -b flag implies -o flag on Windows XP/2003. CORE-19006 (#5377)
partially 0.4.15-dev-6211-g 40864bc [NETSTAT] Fix crash when parsing the protocol CORE-19005 (#5363)
0.4.15-dev-3338-g 0e75fc9 [NETSTAT] Fix coverity #1477187 "Double free" (#4069) CORE-17831 [I ported this double-free-fix earlier already into releases/0.4.13 & releases/0.4.14 and it didn't affect any older releases than that]
partially 0.4.14-dev-479-g 1fa2780 [NETSTAT] Fix output formats
0.4.13-dev-584-g 5e10c4e [NETSTAT] ShowUdpTable(): Fix "tcp" copypasta (#1699)
partially 0.4.13-dev-579-g b695971 [NETSTAT] Simplify some code
partially 0.4.13-dev-578-g ab7dc56 [NETSTAT] Formatting
partially 0.4.13-dev-519-g dda5ec4 [NETSTAT] Simplify DoFormatMessage() (just the changed retval)
0.4.11-dev-820-g 29c883e [NETSTAT] Add support for displaying UDP connections owning process
0.4.11-dev-814-g 2b55073 [NETSTAT] Add support for displaying TCP connections owning process
JoachimHenze added a commit that referenced this pull request Jul 5, 2023
@JoachimHenze
[0.4.9][NETSTAT] Picky Backports up to master-state 2023-07-06
f45b085 
0.4.15-dev-6256-g 8ef47d2 [NETSTAT] Optimize a bit (#5405)
partially 0.4.15-dev-6245-g 5ee97b9 [NETSTAT] -b flag implies -o flag on Windows XP/2003. CORE-19006 (#5377)
partially 0.4.15-dev-6211-g 40864bc [NETSTAT] Fix crash when parsing the protocol CORE-19005 (#5363)
0.4.15-dev-3338-g 0e75fc9 [NETSTAT] Fix coverity #1477187 "Double free" (#4069) CORE-17831 [I ported this double-free-fix earlier already into releases/0.4.13 & releases/0.4.14 and it didn't affect any older releases than that]
partially 0.4.14-dev-479-g 1fa2780 [NETSTAT] Fix output formats
0.4.13-dev-584-g 5e10c4e [NETSTAT] ShowUdpTable(): Fix "tcp" copypasta (#1699)
partially 0.4.13-dev-579-g b695971 [NETSTAT] Simplify some code
partially 0.4.13-dev-578-g ab7dc56 [NETSTAT] Formatting
partially 0.4.13-dev-519-g dda5ec4 [NETSTAT] Simplify DoFormatMessage() (just the changed retval)
0.4.11-dev-820-g 29c883e [NETSTAT] Add support for displaying UDP connections owning process
0.4.11-dev-814-g 2b55073 [NETSTAT] Add support for displaying TCP connections owning process
JoachimHenze added a commit that referenced this pull request Jul 5, 2023
@JoachimHenze
[0.4.8][NETSTAT] Picky Backports up to master-state 2023-07-06
85b87fb 
0.4.15-dev-6256-g 8ef47d2 [NETSTAT] Optimize a bit (#5405)
partially 0.4.15-dev-6245-g 5ee97b9 [NETSTAT] -b flag implies -o flag on Windows XP/2003. CORE-19006 (#5377)
partially 0.4.15-dev-6211-g 40864bc [NETSTAT] Fix crash when parsing the protocol CORE-19005 (#5363)
0.4.15-dev-3338-g 0e75fc9 [NETSTAT] Fix coverity #1477187 "Double free" (#4069) CORE-17831 [I ported this double-free-fix earlier already into releases/0.4.13 & releases/0.4.14 and it didn't affect any older releases than that]
partially 0.4.14-dev-479-g 1fa2780 [NETSTAT] Fix output formats
0.4.13-dev-584-g 5e10c4e [NETSTAT] ShowUdpTable(): Fix "tcp" copypasta (#1699)
partially 0.4.13-dev-579-g b695971 [NETSTAT] Simplify some code
partially 0.4.13-dev-578-g ab7dc56 [NETSTAT] Formatting
partially 0.4.13-dev-519-g dda5ec4 [NETSTAT] Simplify DoFormatMessage() (just the changed retval)
0.4.11-dev-820-g 29c883e [NETSTAT] Add support for displaying UDP connections owning process
0.4.11-dev-814-g 2b55073 [NETSTAT] Add support for displaying TCP connections owning process
JoachimHenze added a commit that referenced this pull request Jul 5, 2023
@JoachimHenze
[0.4.7][NETSTAT] Picky Backports up to master-state 2023-07-06
0654a0a 
0.4.15-dev-6256-g 8ef47d2 [NETSTAT] Optimize a bit (#5405)
partially 0.4.15-dev-6245-g 5ee97b9 [NETSTAT] -b flag implies -o flag on Windows XP/2003. CORE-19006 (#5377)
partially 0.4.15-dev-6211-g 40864bc [NETSTAT] Fix crash when parsing the protocol CORE-19005 (#5363)
0.4.15-dev-3338-g 0e75fc9 [NETSTAT] Fix coverity #1477187 "Double free" (#4069) CORE-17831 [I ported this double-free-fix earlier already into releases/0.4.13 & releases/0.4.14 and it didn't affect any older releases than that]
partially 0.4.14-dev-479-g 1fa2780 [NETSTAT] Fix output formats
0.4.13-dev-584-g 5e10c4e [NETSTAT] ShowUdpTable(): Fix "tcp" copypasta (#1699)
partially 0.4.13-dev-579-g b695971 [NETSTAT] Simplify some code
partially 0.4.13-dev-578-g ab7dc56 [NETSTAT] Formatting
partially 0.4.13-dev-519-g dda5ec4 [NETSTAT] Simplify DoFormatMessage() (just the changed retval)
0.4.11-dev-820-g 29c883e [NETSTAT] Add support for displaying UDP connections owning process
0.4.11-dev-814-g 2b55073 [NETSTAT] Add support for displaying TCP connections owning process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HBelusca HBelusca HBelusca approved these changes

@SergeGautherie SergeGautherie SergeGautherie approved these changes

@JoachimHenze JoachimHenze JoachimHenze approved these changes

Assignees
No one assigned
Labels
bugfix For bugfix PRs. no squash merge Author has no full name in GitHub profile, either merge by rebase or manually
Projects
ReactOS PRs
  
Done
Milestone
No milestone
7 participants
@omoiti @learn-more @HBelusca @ThFabba @SergeGautherie @JoachimHenze @binarymaster