Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASKMGR] Application Page: Fix "Go To Process" item selection #4448

Closed

Conversation

TAN-Gaming
Copy link
Contributor

@TAN-Gaming TAN-Gaming commented Apr 13, 2022

Purpose

Fix "Go To Process" selecting wrong process in the process page

@@ -944,6 +944,8 @@ void ApplicationPage_OnGotoProcess(void)
i = ProcGetIndexByProcessId(dwProcessId);
if (i != -1)
{
ListView_SetSelectionMark(hProcessPageListCtrl, i);
Copy link
Contributor

@HBelusca HBelusca Apr 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this differ with the SetItemState from below? (is there also some sort of visual difference, with and without that line?) -- Note that this is this sort of "explanation" that was to be given into the "Purpose" of the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without that line, it selects wrong process in the process page.

ListView_SetItemState only shows process selection but it doesn't change the selected index.

You can reproduce the bug by selecting "Properties" after "Go To Process"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you mean, that setitemstate puts the "blue" around the process, but the "selected" item with dotted rectangle is still at the old process?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot reproduce this problem on unpatched Task Manager in Windows 10. Need to check on XP/2003.

@TAN-Gaming
Copy link
Contributor Author

The problem maybe in another module, taskmgr works fine on Windows.

@TAN-Gaming TAN-Gaming closed this Apr 13, 2022
@TAN-Gaming TAN-Gaming deleted the tangaming-taskmgr-fix-1 branch April 19, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants