[RTL][NTDLL_APITEST] Implement RtlRemovePrivileges #4614

RatinCN · 2022-08-19T15:45:51Z

Implement RtlRemovePrivileges

sdk/include/ndk/rtlfuncs.h

sdk/lib/rtl/priv.c

HBelusca · 2022-08-21T15:18:36Z

Ah, and since this is also a new function, please write an apitest for it in order to document and test its functioning, following the existing examples of
https://git.reactos.org/?p=reactos.git;a=tree;f=modules/rostests/apitests/ntdll;h=1b71170096ae03425f27561db49de82d05391f4d;hb=HEAD

sdk/include/ndk/rtlfuncs.h

GeoB99 · 2022-08-21T17:36:21Z

sdk/lib/rtl/priv.c

+                    IN ULONG PrivilegeCount)
+{
+    DPRINT("RtlRemovePrivileges(%p, %p, %u)\n", TokenHandle, PrivilegesToKeep, PrivilegeCount);
+


You wouldn't want your RtlRemovePrivileges to explode in your face if the current IRQL is inappropriate for the function to do its work. Use PAGED_CODE_RTL().

This RTL function exported from ntdll.dll in user-mode, in this case, PAGED_CODE_RTL() is not necessary?

There can be NTDLL functions that can be used in kernel mode on-demand. Is this RtlRemovePrivileges strictly used for user mode system components or can it have its usage in kernel mode too? If the former then you might not need PAGED_CODE_RTL(), otherwise you have to use it.

Yes, RtlRemovePrivileges is exported in user-mode only (in Windows), not in kernel-mode, like RtlAdjustPrivilege but new for NT 6.0+

@GeoB99 : Normally the RTL should be compiled twice: once for the kernel (making it use possible kernel-specific defines), and once for user-mode (for ntdll). We don't do that yet, and as a result we may end up (in non-optimized builds) with user-mode-only functions (like this one) being added in the kernel but being never used.

sdk/lib/rtl/priv.c

sdk/include/ndk/rtlfuncs.h

sdk/lib/rtl/priv.c

RatinCN · 2022-09-04T12:50:00Z

Ok to go? @HBelusca @GeoB99 @tkreuzer @ThFabba

RatinCN · 2022-09-26T13:22:13Z

ntdll.dll and ntdll_apitest.exe complied without NTDDK_VERSION (temporarily removed to run this test) and run on ReactOS. In formal build (NTDDK_VERSION lower than Vista), this function will not involved and api test will skipped.

sdk/include/ndk/rtlfuncs.h

sdk/lib/rtl/priv.c

HBelusca · 2022-09-26T13:51:03Z

sdk/lib/rtl/priv.c

+                    IN ULONG PrivilegeCount)
+{
+    DPRINT("RtlRemovePrivileges(%p, %p, %u)\n", TokenHandle, PrivilegesToKeep, PrivilegeCount);
+


@GeoB99 : Normally the RTL should be compiled twice: once for the kernel (making it use possible kernel-specific defines), and once for user-mode (for ntdll). We don't do that yet, and as a result we may end up (in non-optimized builds) with user-mode-only functions (like this one) being added in the kernel but being never used.

sdk/lib/rtl/priv.c

HBelusca · 2022-09-26T15:48:02Z

ntdll.dll and ntdll_apitest.exe complied without NTDDK_VERSION (temporarily removed to run this test) and run on ReactOS. In formal build (NTDDK_VERSION lower than Vista), this function will not involved and api test will skipped.

Does this test pass OK on Windows 7+ ?

RatinCN · 2022-09-28T13:04:54Z

ntdll.dll and ntdll_apitest.exe complied without NTDDK_VERSION (temporarily removed to run this test) and run on ReactOS. In formal build (NTDDK_VERSION lower than Vista), this function will not involved and api test will skipped.

Does this test pass OK on Windows 7+ ?

Yes, this apitest also passed in my Win7 and Win11:

sdk/lib/rtl/priv.c

HBelusca · 2022-10-04T21:44:03Z

Please ensure that

is enabled in the PRs so that if there are (for example) last-time minor formatting/typos suggestions to be applied to it, they can be applied by the person who will commit the PR into master, instead of waiting for PR author / making a separate branch and then manually closing the PR.

RatinCN · 2022-10-05T06:08:27Z

Please ensure that is enabled in the PRs so that if there are (for example) last-time minor formatting/typos suggestions to be applied to it, they can be applied by the person who will commit the PR into master, instead of waiting for PR author / making a separate branch and then manually closing the PR.

Done

sdk/lib/rtl/priv.c

RatinCN requested review from HeisSpiter, learn-more, ThFabba and tkreuzer as code owners August 19, 2022 15:45

HBelusca requested changes Aug 19, 2022

View reviewed changes

HBelusca added the NT6+ For PRs that aim at implementing NT6+ functionality. label Aug 19, 2022

binarymaster added the enhancement For PRs with an enhancement/new feature. label Aug 21, 2022

binarymaster added this to New PRs in ReactOS PRs via automation Aug 21, 2022

binarymaster moved this from New PRs to WIP / Waiting on contributor in ReactOS PRs Aug 21, 2022

HBelusca added the needs tests The proposed changes should be supported by tests to ensure their correctness. label Aug 21, 2022

GeoB99 self-requested a review August 21, 2022 15:41

GeoB99 requested changes Aug 21, 2022

View reviewed changes

tkreuzer reviewed Aug 23, 2022

View reviewed changes

sdk/include/ndk/rtlfuncs.h Outdated Show resolved Hide resolved

sdk/lib/rtl/priv.c Outdated Show resolved Hide resolved

sdk/lib/rtl/priv.c Outdated Show resolved Hide resolved

sdk/lib/rtl/priv.c Outdated Show resolved Hide resolved

RatinCN force-pushed the Impl_RtlRemovePrivileges branch from d159a1f to f085c62 Compare August 30, 2022 17:13

github-actions bot added the ROSTESTS Label for ROS testcases PRs. label Aug 30, 2022

RatinCN requested review from GeoB99 and HBelusca and removed request for learn-more, HeisSpiter, ThFabba and GeoB99 August 30, 2022 17:19

binarymaster changed the title ~~[RTL] Implement RtlRemovePrivileges~~ [RTL][NTDLL_APITEST] Implement RtlRemovePrivileges Sep 13, 2022

binarymaster removed the needs tests The proposed changes should be supported by tests to ensure their correctness. label Sep 13, 2022

HBelusca reviewed Sep 26, 2022

View reviewed changes

[RTL] Implement RtlRemovePrivileges

c96e746

RatinCN force-pushed the Impl_RtlRemovePrivileges branch from f085c62 to c96e746 Compare September 28, 2022 13:01

RatinCN requested a review from HBelusca September 30, 2022 03:54

HBelusca approved these changes Sep 30, 2022

View reviewed changes

sdk/lib/rtl/priv.c Show resolved Hide resolved

sdk/lib/rtl/priv.c Outdated Show resolved Hide resolved

HBelusca requested a review from ThFabba October 1, 2022 13:20

HBelusca approved these changes Oct 5, 2022

View reviewed changes

sdk/lib/rtl/priv.c Show resolved Hide resolved

Minor formatting

8d53d53

HBelusca merged commit badd970 into reactos:master Oct 5, 2022

ReactOS PRs automation moved this from WIP / Waiting on contributor to Done Oct 5, 2022

RatinCN deleted the Impl_RtlRemovePrivileges branch October 7, 2022 07:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RTL][NTDLL_APITEST] Implement RtlRemovePrivileges #4614

[RTL][NTDLL_APITEST] Implement RtlRemovePrivileges #4614

RatinCN commented Aug 19, 2022

HBelusca commented Aug 21, 2022

GeoB99 Aug 21, 2022

RatinCN Aug 22, 2022

GeoB99 Aug 22, 2022

RatinCN Aug 23, 2022

HBelusca Sep 26, 2022

RatinCN commented Sep 4, 2022

RatinCN commented Sep 26, 2022 •

edited

HBelusca Sep 26, 2022

HBelusca commented Sep 26, 2022

RatinCN commented Sep 28, 2022

HBelusca commented Oct 4, 2022

RatinCN commented Oct 5, 2022 •

edited

[RTL][NTDLL_APITEST] Implement RtlRemovePrivileges #4614

[RTL][NTDLL_APITEST] Implement RtlRemovePrivileges #4614

Conversation

RatinCN commented Aug 19, 2022

HBelusca commented Aug 21, 2022

GeoB99 Aug 21, 2022

Choose a reason for hiding this comment

RatinCN Aug 22, 2022

Choose a reason for hiding this comment

GeoB99 Aug 22, 2022

Choose a reason for hiding this comment

RatinCN Aug 23, 2022

Choose a reason for hiding this comment

HBelusca Sep 26, 2022

Choose a reason for hiding this comment

RatinCN commented Sep 4, 2022

RatinCN commented Sep 26, 2022 • edited

HBelusca Sep 26, 2022

Choose a reason for hiding this comment

HBelusca commented Sep 26, 2022

RatinCN commented Sep 28, 2022

HBelusca commented Oct 4, 2022

RatinCN commented Oct 5, 2022 • edited

RatinCN commented Sep 26, 2022 •

edited

RatinCN commented Oct 5, 2022 •

edited