Partially sync Regedit to Wine-7.17 #4717
Conversation
- regproc.c and regedit.c are now in sync. - some other mostly depending fixes for the remaining files
binarymaster
added
enhancement
|
"Maybe" CORE-8141? Why not testing it? |
I did. It doesn't fix the error: I removed the mention of the ticket. |
| } | ||
| void WINAPIV output_message(unsigned int id, ...) | ||
| { | ||
| WCHAR fmt[1536]; |
There was a problem hiding this comment.
.....
This is the readme text size?
There was a problem hiding this comment.
I hope so. :D I didn't measure the string.
There was a problem hiding this comment.
As far as I understand the code, the worst-case-impact on too long translations, would be cutting off the string.
Which is not optimal, but most likely tolerable. Better than corruption at least.
Do you agree @learn-more that we are safe from corruption?
There was a problem hiding this comment.
Imho the many fixed tests do justify that PR.
A lot of work for updating the translations will follow most likely.
Only thing that I see could be improved is the fixed size of the helpstring. That might give problems, if translators would chose very long translations maybe.
|
gonzoMD you touched the tests as well. The old untouched tests for regedit were 100% successful on Win2k3sp2. see |
Next week, I'll be back to my PC where I have my 2k3 VM. I'll do then. Maybe I get the stuff set up to my other PC earlier too. |
Tested on XP SP3 and Win2k3 R2 SP2, result is the same.
|
Sbasiba |
* [REGEDIT] Partially Sync to Wine 7.17 - regproc.c and regedit.c are now in sync. - some other mostly depending fixes for the remaining files * [REGEDIT_WINETEST] Sync to Wine-7.0
Purpose
Partially sync Regedit to Wine-7.17
JIRA issue: Don't know.
Proposed changes
[REGEDIT] Partially Sync to Wine-7.17
[REGEDIT_WINETEST] Sync to Wine-7.0
Before:
After: