Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXPLORER] Hide Start Menu before Run dialog #4823

Merged
merged 5 commits into from Nov 2, 2022
Merged

[EXPLORER] Hide Start Menu before Run dialog #4823

merged 5 commits into from Nov 2, 2022

Conversation

katahiromz
Copy link
Contributor

@katahiromz katahiromz commented Oct 29, 2022 •
edited

Purpose

JIRA issue: CORE-13330

Proposed changes

  • Add HideStartMenu helper method.
  • Hide Start Menu before opening Run dialog.

Comparison

BEFORE:
before2

AFTER:
after2

@HBelusca
Copy link
Contributor

But why using it only just for the run dialog?

@binarymaster binarymaster added bugfix For bugfix PRs. shell All PR's related to the shell (and shell extensions) labels Oct 29, 2022
@katahiromz
Copy link
Contributor Author

Log-off and shutdown are not processing taskbar messages.

@katahiromz

This comment was marked as outdated.

Sign in to view
@katahiromz katahiromz added the modding Theming, visual designing modifications of ReactOS label Oct 30, 2022
@katahiromz katahiromz added this to New PRs in ReactOS PRs via automation Oct 30, 2022
@katahiromz katahiromz changed the title [EXPLORER] Hide Start Menu before Run dialog [EXPLORER] Hide Start Menu before Run/LogOff/Shutdown Oct 30, 2022
@binarymaster
Copy link
Member

BEFORE:

@katahiromz there was a separate ticket regarding these remaining parts on the taskbar when clicking Shutdown.

Unable to find that ticket right now, maybe @JoachimHenze remembers it.

@katahiromz

This comment was marked as outdated.

Sign in to view
@binarymaster
Copy link
Member

Please note, according to the comments in CORE-16451, correct bugfix should be outside of the shell: https://jira.reactos.org/browse/CORE-16451?focusedCommentId=117981&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-117981

@katahiromz
Copy link
Contributor Author

This PR is just a workaround. Closed due to wrong implementation.

@katahiromz katahiromz closed this Oct 31, 2022
ReactOS PRs automation moved this from New PRs to Done Oct 31, 2022
@katahiromz
Copy link
Contributor Author

Deleting message loop workaround, I will retry.

@katahiromz katahiromz reopened this Oct 31, 2022
ReactOS PRs automation moved this from Done to New PRs Oct 31, 2022
@katahiromz katahiromz changed the title [EXPLORER] Hide Start Menu before Run/LogOff/Shutdown [EXPLORER] Hide Start Menu before Run dialog Oct 31, 2022
@katahiromz katahiromz removed the modding Theming, visual designing modifications of ReactOS label Oct 31, 2022
@learn-more
Copy link
Member

Please note, according to the comments in CORE-16451, correct bugfix should be outside of the shell: https://jira.reactos.org/browse/CORE-16451?focusedCommentId=117981&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-117981

That is a comment specifically about the dimming of the screen?

@binarymaster
Copy link
Member

That is a comment specifically about the dimming of the screen?

It's specifically regarding the glitch of the part of start menu contents remaining on the taskbar (the comment above was marked as outdated).

@katahiromz katahiromz merged commit 802a87d into reactos:master Nov 2, 2022
ReactOS PRs automation moved this from New PRs to Done Nov 2, 2022
@katahiromz katahiromz deleted the run-dialog branch November 2, 2022 02:29
@HBelusca
Copy link
Contributor

HBelusca commented Nov 2, 2022

Has this PR been reviewed?

@learn-more
Copy link
Member

Has this PR been reviewed?

When exactly would we have had time for that?

JoachimHenze pushed a commit that referenced this pull request Nov 4, 2022
@katahiromz @JoachimHenze
[EXPLORER] Hide Start Menu before Run dialog (#4823)
06525ec 
- Add HideStartMenu helper method.
- Hide Start Menu before opening Run dialog.
CORE-13330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix For bugfix PRs. shell All PR's related to the shell (and shell extensions)
Projects
ReactOS PRs
  
Done
Milestone
No milestone
4 participants
@katahiromz @HBelusca @binarymaster @learn-more