[RAPPS] Rework application handling #5070
Conversation
learn-more
force-pushed
the
rapps_cleanup
branch
from
b57eeb5
to
0f4a5c9
Compare
| * PURPOSE: Classes for working with available applications | ||
| * COPYRIGHT: Copyright 2017 Alexander Shaposhnikov (sanchaez@reactos.org) | ||
| * Copyright 2020 He Yang (1160386205@qq.com) | ||
| * Copyright 2021-2023 Mark Jansen <mark.jansen@reactos.org> |
There was a problem hiding this comment.
the space indentation between Alex and his email, and He and his email should be stripped. Especially since you already decided to not follow that nonsense-padding-attempt with your own email.
Some other newly created files are also affected. I will only mention that once.
| InstallLocalTime.wDay = wcstol(m_szInstallDate.Mid(6, 2).GetString(), NULL, 10); | ||
| } | ||
| } | ||
| // It might be a DWORD (Unix timestamp). try again. |
There was a problem hiding this comment.
The comment is very good regarding its content, but its positioning (before the else) is awful. Please move it!
base/applications/rapps/appview.cpp
Outdated
| @@ -1410,7 +1252,7 @@ BOOL CAppsListView::SetDisplayAppType(APPLICATION_VIEW_TYPE AppType) | |||
| SetCheckboxesVisible(TRUE); | |||
| break; | |||
|
|
|||
| case AppViewTypeEmpty: | |||
| //case AppViewTypeEmpty: | |||
| default: | |||
| break; | |||
There was a problem hiding this comment.
what is the reasoning behind keeping that commented line?
learn-more
force-pushed
the
rapps_cleanup
branch
from
0f4a5c9
to
48932bb
Compare
|
Because formatting was so important to @HBelusca and @JoachimHenze that they left almost 30 individual reviews with one comment per review, If the style is still not to your liking, feel free to fix the |
learn-more
force-pushed
the
rapps_cleanup
branch
from
48932bb
to
33c2903
Compare
Previously, there would be function duplication between installed and available applications. Now this is handled with polymorphism, which allows to re-use a lot of code. Additionally, toolbar buttons are properly disabled now. The mutex used to guard rapps' single instance is renamed, so that the 'new' and old rapps can be run at the same time for testing. CORE-18459
Previously, there would be function duplication between installed and available applications. Now this is handled with polymorphism, which allows to re-use a lot of code. Additionally, toolbar buttons are properly disabled now. The mutex used to guard rapps' single instance is renamed, so that the 'new' and old rapps can be run at the same time for testing.