[EXT2FS] Align with upstream and mark ReactOS diff #5245
Conversation
| if (Property2->bHidingPrefix == Vcb->bHidingPrefix) { | ||
| #else | ||
| if (Property2->bHidingPrefix = Vcb->bHidingPrefix) { |
There was a problem hiding this comment.
Is that a bug in the original code, that we fixed in ReactOS? Or is the original code correct here, and we just tried to mute some static code check and did it wrong? (The same thing can also be found at a 2nd location within this file)
There was a problem hiding this comment.
it's a bug in the original code that we fixed indeed. After this PR, I'll try to upstream those fixes. but unfortunately, as stated in the Jira ticket, upstream seems to be abandoned. only https://github.com/bobranten/Ext4Fsd seems to still be around
There was a problem hiding this comment.
It would be worth looking at whether the ext4fsd of Bo Branten also covers ext2 and 3, and if so, how much does the code change wrt. that ext2/3 driver we have. In case of positive observations, maybe one could think about updating to that ext4fsd ?
There was a problem hiding this comment.
Yes, I'll try to have a look into it later :)
There was a problem hiding this comment.
It would be worth looking at whether the ext4fsd of Bo Branten also covers ext2 and 3, and if so, how much does the code change wrt. that ext2/3 driver we have. In case of positive observations, maybe one could think about updating to that ext4fsd ?
According to its readme it also covers ext2/3.
There are 2 pro arguments.
- It additionally supports a more modern file system
- It is under active development
We should really think about switching to this never driver.
There was a problem hiding this comment.
it's a bug in the original code that we fixed indeed. After this PR, I'll try to upstream those fixes. but unfortunately, as stated in the Jira ticket, upstream seems to be abandoned. only https://github.com/bobranten/Ext4Fsd seems to still be around
This also has this bug, so it's worth to send a PR. See https://github.com/bobranten/Ext4Fsd/blob/d9da413ad28afa3c0519d730da60f8598bbaea32/Ext4Fsd/devctl.c#L514
And line 523 too.
There was a problem hiding this comment.
when this PR is merged, I'll open a PR on ext4fsd with ReactOS fixes. Then I'll see to use Ext4fsd in ROS :)
we are now re-aligned with upstream 0.69
Vince1171
force-pushed
the
ext2_upstream_realignment
branch
from
941afb9
to
6f2a312
Compare
HBelusca
changed the title
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
|
I suppose that those changes (restoring the proper ifdefs wrt. upstream) doesn't break reading EXT2/3 partitions with ReactOS. |
no break indeed ^^
|
HBelusca
added
the
3rd party sync
|
Thanks for the sync! |
Purpose
add ifdefs to distinguish ReactOS code/fixes from the upstream code.
NOTE: there are no new features in this PR, we stay with upstream version 0.69.
JIRA issue: CORE-18645
Proposed changes