Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BROWSEUI] Add locked toolbar state persistence #5350

Merged
merged 11 commits into from Jun 20, 2023

Conversation

cbialorucki
Copy link
Contributor

Purpose

Store the state of the explorer toolbar, locked or unlocked, in the proper registry location and set the proper toolbar state when initialized.

JIRA issue: CORE-9094

Proposed changes

  • Set HKEY_CURRENT_USER\Software\Microsoft\Internet Explorer\Toolbar\Locked to 1 when the explorer toolbar is locked, 0 when the toolbar is unlocked.
  • Query HKEY_CURRENT_USER\Software\Microsoft\Internet Explorer\Toolbar\Locked when the toolbar is initialized to set the correct locked state.
  • Set the default state of the toolbar to locked if the registry key does not exist, matching the behavior of Windows Server 2003.

@binarymaster binarymaster added enhancement For PRs with an enhancement/new feature. bugfix For bugfix PRs. shell All PR's related to the shell (and shell extensions) labels Jun 17, 2023
@binarymaster binarymaster added this to New PRs in ReactOS PRs via automation Jun 17, 2023
dll/win32/browseui/internettoolbar.cpp Outdated Show resolved Hide resolved
dll/win32/browseui/internettoolbar.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@JoachimHenze JoachimHenze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some EOL whitespace should be stripped.

dll/win32/browseui/internettoolbar.cpp Outdated Show resolved Hide resolved
dll/win32/browseui/internettoolbar.cpp Outdated Show resolved Hide resolved
dll/win32/browseui/internettoolbar.cpp Outdated Show resolved Hide resolved
ReactOS PRs automation moved this from New PRs to WIP / Waiting on contributor Jun 18, 2023
cbialorucki and others added 3 commits June 17, 2023 21:58
Co-authored-by: Joachim Henze <joachim.henze@reactos.org>
Co-authored-by: Joachim Henze <joachim.henze@reactos.org>
Co-authored-by: Joachim Henze <joachim.henze@reactos.org>
@cbialorucki
Copy link
Contributor Author

cbialorucki commented Jun 18, 2023

Some EOL whitespace should be stripped.

Whitespace removed.

dll/win32/browseui/internettoolbar.cpp Outdated Show resolved Hide resolved
dll/win32/browseui/internettoolbar.cpp Outdated Show resolved Hide resolved
dll/win32/browseui/internettoolbar.cpp Show resolved Hide resolved
dll/win32/browseui/internettoolbar.cpp Outdated Show resolved Hide resolved
dll/win32/browseui/internettoolbar.cpp Outdated Show resolved Hide resolved
@HBelusca
Copy link
Contributor

lgtm otherwise.

Whitespace was added per the suggestions of a project maintainer.

Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
dll/win32/browseui/internettoolbar.cpp Outdated Show resolved Hide resolved
dll/win32/browseui/internettoolbar.cpp Outdated Show resolved Hide resolved
dll/win32/browseui/internettoolbar.cpp Outdated Show resolved Hide resolved
Co-authored-by: Joachim Henze <joachim.henze@reactos.org>
Copy link
Contributor

@JoachimHenze JoachimHenze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please try to answer the questions of hbelusca regarding the casts before merging.

ReactOS PRs automation moved this from WIP / Waiting on contributor to Approved by reviewers Jun 18, 2023
@binarymaster binarymaster changed the title [BROWSEUI] Add Locked Toolbar State Persistence [BROWSEUI] Add locked toolbar state persistence Jun 19, 2023
@HBelusca HBelusca requested a review from learn-more June 19, 2023 16:11
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>
@HBelusca HBelusca merged commit f203ad5 into reactos:master Jun 20, 2023
33 checks passed
ReactOS PRs automation moved this from Approved by reviewers to Done Jun 20, 2023
@HBelusca
Copy link
Contributor

Thanks for the PR!

@cbialorucki cbialorucki deleted the lock_toolbar_fix branch June 20, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix For bugfix PRs. enhancement For PRs with an enhancement/new feature. shell All PR's related to the shell (and shell extensions)
Projects
ReactOS PRs
  
Done
6 participants