[MSPAINT] Fix CMainWindow::GetSaveFileName #5356
Conversation
| { | ||
| if (aguidFileTypesE[i] == Gdiplus::ImageFormatPNG) | ||
| // Choose PNG | ||
| wcscat(pszFile, L".png"); |
There was a problem hiding this comment.
This is not done automatically by the GetSaveFileName function?
How was the original code behaving when running on Windows?
There was a problem hiding this comment.
done automatically
But the extension is in uppercase.
There was a problem hiding this comment.
If I understand "our" (well, Wine...) code, https://git.reactos.org/?p=reactos.git;a=blob;f=dll/win32/comdlg32/filedlg.c;hb=19d88628515506f9392384ae45bc7d38d1e9708a#l3159 is where the extension gets appended. But it doesn't seem to make it upper.
The extensions appear in upper-case:
because the file type strings, that we generate from ATL or whatever, are in uppercase.
It is those strings that need a fix, if needed (TODO: Verify whether the native Windows gdiplus ant ATL CImage also generate the extensions in uppercase or not). Not this hackfix from this PR.
Also, you (yet again... 🙄 ) made a PR that nobody could review because you committed it few hours later. Please definitively stop that.
Purpose
Fix filename extension cases and "File Type" field.
JIRA issue: CORE-18867
Proposed changes
.pngto the filename.TODO
Comparison
Tested on Win10.
BEFORE:
AFTER: