[GDI32_APITEST] Remove "todo_ros" for SetDIBitsToDevice tests that work now #5402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HBelusca
approved these changes
Jul 4, 2023
Yes, after the commit of #5227. |
JoachimHenze
approved these changes
Jul 4, 2023
binarymaster
changed the title
gonzoMD
approved these changes
Jul 8, 2023
|
Thanks @binarymaster for the commit and @JoachimHenze, @HBelusca and @gonzoMD for your approvals. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove some outdated 'todo_ros' qualifiers.
JIRA issue: ROSTESTS-384
Proposed changes
Remove 'todo_ros' in six (6) places.
Testbot results:
SetDIBitsToDevice_fix.patch JID65977 on top of 0.4.15-dev-6253-g7fafeb6
VBox: https://reactos.org/testman/compare.php?ids=88092,88095 LGTM
KVM: https://reactos.org/testman/compare.php?ids=88091,88094 LGTM