Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHELL32] Don't display missing applications in Open with. CORE-19117 #5587

Merged
merged 7 commits into from Nov 15, 2023

Conversation

whindsaks
Copy link
Contributor

Purpose

Don't display applications that don't exist.

JIRA issue: CORE-19117

I verified the behavior on XP. Exe files that no longer exist are hidden but their registry entry is not deleted.

@binarymaster binarymaster added enhancement For PRs with an enhancement/new feature. bugfix For bugfix PRs. shell All PR's related to the shell (and shell extensions) labels Aug 18, 2023
@binarymaster binarymaster added this to New PRs in ReactOS PRs via automation Aug 18, 2023
dll/win32/shell32/COpenWithMenu.cpp Outdated Show resolved Hide resolved
dll/win32/shell32/COpenWithMenu.cpp Outdated Show resolved Hide resolved
dll/win32/shell32/COpenWithMenu.cpp Outdated Show resolved Hide resolved
dll/win32/shell32/COpenWithMenu.cpp Show resolved Hide resolved
ReactOS PRs automation moved this from New PRs to Approved by reviewers Nov 13, 2023
@GeoB99 GeoB99 merged commit 51ba3b1 into reactos:master Nov 15, 2023
37 checks passed
ReactOS PRs automation moved this from Approved by reviewers to Done Nov 15, 2023
@whindsaks whindsaks deleted the CORE-19117-OpenWithMissingFile branch November 20, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix For bugfix PRs. enhancement For PRs with an enhancement/new feature. shell All PR's related to the shell (and shell extensions)
Projects
ReactOS PRs
  
Done
6 participants